Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose mvtools dict in CMDegrain #1

Open
NSQY opened this issue May 28, 2022 · 1 comment
Open

Expose mvtools dict in CMDegrain #1

NSQY opened this issue May 28, 2022 · 1 comment

Comments

@NSQY
Copy link

NSQY commented May 28, 2022

I would for instance prefer to use DCT=5, which uses SATD instead of SAD.

@End-of-Eternity
Copy link
Owner

Sorry for the delay in response. I've had a think about this, and while I do like the idea, I'm not sure how to best implement it.

The problem is that there are four different mvtools functions called within cmdegrain, super, analy[sz]e, recalculate and degrain. The main ones that we care about would probably just be super and analysze, which share many parameters, but that's still two sets of kwargs, and passing two dicts is kind of ugly. Not only that, but recalculate is called multiple times with different arguments for block size - I'm not sure how to handle this nicely. If you (or anyone) can come up with a nice way to make this into function signature without it looking horrible and without the logic being overly complex then feel free, otherwise my suggestion would just be the (somewhat annoying, sorry) method of copy pasting my function and hardcoding the arguments yourself.

I do however quite like the ability to set DCT (across all relevant functions), so will implement that seperately now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants