Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data attribute #3

Open
TheUntraceable opened this issue Jan 22, 2022 · 7 comments
Open

Data attribute #3

TheUntraceable opened this issue Jan 22, 2022 · 7 comments
Assignees

Comments

@TheUntraceable
Copy link
Member

For most of the classes we have, we depend on a data argument, we also include a client arg for some objects. We should add a data attribute that will represent the data that we took in so that people can modify it to their needs if we don't make an update and there's a new feature. Shouldn't take too long to add but gonna be a little tedious to add.

@TheUntraceable
Copy link
Member Author

I'll do this before the major release of 1.0 because it'll need me to go to every class and show the data attribute.

@nav-github01001
Copy link
Member

@TheUntraceable it is done

@TheUntraceable
Copy link
Member Author

What

@nav-github01001
Copy link
Member

Done it rt

@TheUntraceable
Copy link
Member Author

Not really

@EmmmaTech
Copy link

We should add a data attribute that will represent the data that we took in so that people can modify it to their needs if we don't make an update and there's a new feature. Shouldn't take too long to add but gonna be a little tedious to add.

This doesn't make sense. With objects returned from the Discord API, they shouldn't be modified locally because those changes won't be in sync with the Discord API. In turn, this will cause confusion.

@TheUntraceable
Copy link
Member Author

The point of this is so that even if I stop maintaining the library, you should still be able to use it.

New attribute? It's in the .data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants