Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop vendoring ace.js and panzoom #32

Open
Godsmith opened this issue Dec 5, 2024 · 0 comments
Open

Stop vendoring ace.js and panzoom #32

Godsmith opened this issue Dec 5, 2024 · 0 comments

Comments

@Godsmith
Copy link
Contributor

Godsmith commented Dec 5, 2024

I think we should stop vendoring these files and instead retrieve them from a CDN.

It doesn't make sense that we are retrieving some things, like bootstrap, from a CDN but other things we vendor. Also, it gives the impression that we have made changes to the code, but we have not.

This will also make grepping in the repo return less hits.

Not sure about the ace.js themes. If they are not in a CDN or similar they can remain, but then we have to add license information to the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant