Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write jellyfish book #44

Open
zhenfeizhang opened this issue Mar 15, 2022 · 6 comments
Open

write jellyfish book #44

zhenfeizhang opened this issue Mar 15, 2022 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@zhenfeizhang
Copy link
Contributor

something similar to https://github.com/zcash/halo2/tree/main/book would be really helpful

@zhenfeizhang zhenfeizhang added the documentation Improvements or additions to documentation label Mar 15, 2022
@zhenfeizhang zhenfeizhang self-assigned this Apr 5, 2022
@chancharles92
Copy link
Contributor

Hi @zhenfeizhang @alxiong , how about assigning this issue to @mrain so that he can be more familiar with the codebase along the process?

@mrain
Copy link
Contributor

mrain commented Aug 1, 2022

Is it a better way to first enhance the rust doc? The codebase may need better commentations.

@chancharles92
Copy link
Contributor

chancharles92 commented Aug 1, 2022

Is it a better way to first enhance the rust doc? The codebase may need better commentations.

Sounds good

@alxiong
Copy link
Contributor

alxiong commented Aug 2, 2022

Sounds good, the only concern would be, we can improve the documentation more strategically given that our constraint system API (i.e. jf_plonk::circuit::*) might be updated significantly. (contingent on our investigation into Halo2)

I'd say start with jf_plonk::proof_system::*which is likely something we will keep. WDYT? @chancharles92 @mrain

(and, until we have a clear comparison with halo2, plonky2 and zk-garage's API design, our code base would be subject to major changes, and I personally would prefer to write a rustbook after we have a more stable plan.)

@chancharles92
Copy link
Contributor

Sounds good, the only concern would be, we can improve the documentation more strategically given that our constraint system API (i.e. jf_plonk::circuit::*) might be updated significantly. (contingent on our investigation into Halo2)

I'd say start with jf_plonk::proof_system::*which is likely something we will keep. WDYT? @chancharles92 @mrain

(and, until we have a clear comparison with halo2, plonky2 and zk-garage's API design, our code base would be subject to major changes, and I personally would prefer to write a rustbook after we have a more stable plan.)

Sounds good, or @mrain can work on other small issues first (e.g. one of #89 #62 #81), and continue on this after finalizing the circuit front-end.

@zhenfeizhang
Copy link
Contributor Author

Sounds good. It is better to improve the code APIs first before working on this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants