[HOLD for payment 2024-11-11] [$500] Android/iOS - Code blocks are overflowing the app border

[zanyrenney]

Issue is failing #4624 (CC @parasharrajat)

Action Performed:

1. Navigate to a conversation in iOS or Android
2. Send a long message in a code block

Expected Result:

Code block should be displayed in the area of the conversation.

Actual Result:

Code block is partially visible because is overflowing the app border.

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.0.86-2

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ecab5a591272dd78
• Upwork Job ID: 1602379910299570176
• Last Price Increase: 2023-10-19

Issue Owner

Current Issue Owner: @zanyrenney / @zanyrenney

[melvin-bot]

Current assignees @puneetlath and @zanyrenney are eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[zanyrenney]

for @puneetlath @cubuspl42 - we discussed this in DM on Slack. Still going over some of the details and write up of payment details but creating this as a holding/tracking issue.

[parasharrajat]

@zanyrenney Shouldn't I be C+ here?

[zanyrenney]

Yep, i was going to assign you when we had all the details but happy to assign you now @parasharrajat

[cubuspl42]

@puneetlath @zanyrenney Is there any way we could use the status that Expensify is an Incubating partner and Software Mansion is a Partner to get me added to as the Core Contributor, possibly bending the formal requirements?

I'll need to apply changes in low-lever parts of the framework (including ReactCommon, the C++ layer), so it would be awesome to be able to get some feedback and hints on the Core Contributor Discord server.

[AndrewGable]

Hey @cubuspl42 - I think you got great initial feedback by the discussions and proposals process which means you should proceed on creating a pull request and getting feedback there 👍

[puneetlath]

Going to make this a weekly as I think that's a more realistic cadence for us to expect updates on this.

[puneetlath]

At least until Melvin changes it to Daily again 😅

[zanyrenney]

That sounds good to me, thanks @puneetlath

[parasharrajat]

@cubuspl42 Please keep us posted here about new milestones.

[cubuspl42]

The first PR is being reviewed, or at least is supposed to be. The part that I need to modify has been copy-pasted over 3 places for years, and I'm trying to clean that up before adding new features there.

[cubuspl42]

There was some minor initial movement in the mentioned PR, but otherwise nothing for a week.

A cat picture from my private gallery didn't work.

This project will need several PRs, and this one was just moving things around to make the next steps possible.

@AndrewGable

[melvin-bot]

@puneetlath @cubuspl42 @parasharrajat @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[zanyrenney]

Thanks for the update @cubuspl42 - is there something specific you need from @AndrewGable? If it would help to take this issue to slack for a conversation, please feel free to do so and link in the relevant assignees.

[puneetlath]

@cdOut how is this going?

[cdOut]

Hi, sorry for all the delays with updates on this one, I've lost track of the issue due to working on high priority ones at that time. I'm going to pick up this issue and push a solution in the PR by the EOW.

My current solution was flawed as it had a slight delay between opening the report chat and rendering the valid code content, I'll look for a way to style the text as inline with a proper block border on native devices without having to wait for it to render first.

[cdOut]

I found a way to handle this case with a pretty minimal solution that doesn't rely rendering the content first, I've moved the PR into review.

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @parasharrajat, @zanyrenney, @cdOut eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[parasharrajat]

Very close to merge.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Android / iOS] Code blocks are overflowing the app border #44953

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @cdOut does not require payment (Contractor)

[melvin-bot]

@parasharrajat @puneetlath / @zanyrenney The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Couldn't identify as this is very old issue over 3 years old.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not required

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• None

Test:

1. Go into any chat report.
2. Type the suggested message below, it's been prepared for testing purposes:

`thissadasdasdsadsadasdadsadasdasdasdasdasdasdasdasdasdasdsadsadggggggggggggggggg` multilingual 
`https://www.google.com/search?q=google&oq=goog&gs_lcrp=EgZjaHJvbWUqEAgAEAAYgwEY4wIYsQMYgAQyEAgAEAAYgwEY4wIYsQMYgAQyEwgBEC4YgwEYxwEYsQMY0QMYgAQyDQgCEAAYgwEYsQMYgAQyBggDEEUYOzIGCAQQRRg8MgYIBRBFGDwyBggGEEUYPDIGCAcQBRhA0gEHNzM1ajBqN6gCALACAA&sourceid=chrome&ie=UTF-8`

3. Confirm that the message displays and wraps around properly for both IOS and Android native.

Do we agree 👍 or 👎

[parasharrajat]

There won't be any C+ payment for me on this issue, it is part of #4733.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot
• Contributor: @cdOut is from an agency-contributor and not due payment

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1602379910299570176/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[zanyrenney]

#52402 - regression test here.

[zanyrenney]

Payment Summary

Reviewer: @parasharrajat owed $250 via NewDot
Contributor: @cdOut is from an agency-contributor and not due payment - no payment

I've completed the summary and added the regression test. We can close this now.