Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-09-18][$125] Upgrade mapbox and remove patch #48123

Closed
roryabraham opened this issue Aug 27, 2024 · 25 comments
Closed

[HOLD for payment 2024-09-18][$125] Upgrade mapbox and remove patch #48123

roryabraham opened this issue Aug 27, 2024 · 25 comments
Assignees
@suneox @lschurr @roryabraham @abzokhattab
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Aug 27, 2024 •
edited by lschurr
Loading

This issue is just a tracker to upgrade mapbox and remove the patch we added in https://github.com/Expensify/App/pull/45289/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R102

Looks like the build issues are being address upstream in rnmapbox/maps#3593 and we can upgrade to https://github.com/rnmapbox/maps/releases/tag/v10.1.30 and remove the patch.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ed1b0e1397924f45
  • Upwork Job ID: 1828535807455065976
  • Last Price Increase: 2024-08-27
  • Automatic offers:
    • suneox | Reviewer | 103729434
    • abzokhattab | Contributor | 103729436
@roryabraham roryabraham added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 27, 2024
@roryabraham roryabraham self-assigned this Aug 27, 2024
@melvin-bot melvin-bot bot changed the title Upgrade mapbox and remove patch [$250] Upgrade mapbox and remove patch Aug 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ed1b0e1397924f45

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

@roryabraham roryabraham changed the title [$250] Upgrade mapbox and remove patch [$100] Upgrade mapbox and remove patch Aug 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 27, 2024

Upwork job price has been updated to $100

@roryabraham roryabraham changed the title [$100] Upgrade mapbox and remove patch [$125] Upgrade mapbox and remove patch Aug 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 27, 2024

Upwork job price has been updated to $125

@roryabraham roryabraham mentioned this issue Aug 27, 2024
Merged
50 tasks
@Nodebrute
Copy link
Contributor

@roryabraham I can work on this issue.

@roryabraham
Copy link
Contributor Author

For the sake of this proposal, let's lay out the test steps we'll follow to ensure that the new version works as expected

@abzokhattab
Copy link
Contributor

abzokhattab commented Aug 27, 2024 •
edited by github-actions bot
Loading

Edited by proposal-police: This proposal was edited at 2024-08-27 22:21:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Upgrade mapbox and remove patch

What is the root cause of that problem?

The root cause is a compatibility issue between React Native 0.75 and the @rnmapbox/maps package version 10.1.26. A patch was initially applied to address these issues, but the underlying problems are being addressed upstream in rnmapbox/maps by the maintainers so we can remove this patch and upgrade the package instead .

What changes do you think we should make in order to solve the problem?

Upgrade the @rnmapbox/maps package to version 10.1.30, which includes fixes for the React Native 0.75 compatibility issues, and remove the old patch previously applied to this package.

What alternative solutions did you explore? (Optional)

N.A.

@suneox
Copy link
Contributor

suneox commented Aug 28, 2024

@abzokhattab proposal is straightforward to handle the update, so we can go ahead with it.

🎀 👀 🎀 C+ reviewed

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 28, 2024

Current assignee @roryabraham is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 29, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 29, 2024

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 29, 2024

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 2, 2024

@suneox, @lschurr, @roryabraham, @abzokhattab Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
@suneox
Copy link
Contributor

suneox commented Sep 2, 2024

@abzokhattab Could you please provide an ETA for PR?

@melvin-bot melvin-bot bot removed the Overdue label Sep 2, 2024
@abzokhattab abzokhattab mentioned this issue Sep 2, 2024
Merged
48 tasks
@abzokhattab
Copy link
Contributor

working on the PR here #48436

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 6, 2024

@suneox, @lschurr, @roryabraham, @abzokhattab Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2024
@suneox
Copy link
Contributor

suneox commented Sep 6, 2024

Still waiting @abzokhattab change PR status

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Sep 6, 2024
@abzokhattab
Copy link
Contributor

Thanks for your patience i was having a problem upgrading Ruby from v2 to v4 .. the PR is now ready

@MrRefactor
Copy link
Contributor

Could we also bump pod for rnmapbox/maps?
CC: @abzokhattab @roryabraham

@roryabraham
Copy link
Contributor Author

good catch @MrRefactor

@roryabraham roryabraham mentioned this issue Sep 10, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Sep 10, 2024
@roryabraham
Copy link
Contributor Author

Created #48925 to clean that up

@roryabraham roryabraham removed the Reviewing Has a PR in review label Sep 13, 2024
@roryabraham
Copy link
Contributor Author

Sorry for the difficulty with automations not working in this case. Growing pains in the deploy systems.

The PR for this was deployed to prod on 2024-09-11

@roryabraham roryabraham added the Awaiting Payment Auto-added when associated PR is deployed to production label Sep 13, 2024
@roryabraham roryabraham changed the title [$125] Upgrade mapbox and remove patch [HOLD for payment 2024-09-18][$125] Upgrade mapbox and remove patch Sep 13, 2024
@lschurr
Copy link
Contributor

lschurr commented Sep 18, 2024

Which PR fixed the bug on this GH @roryabraham?

It looks like this one wasn't deployed to prod yet: #48436

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 19, 2024
@roryabraham
Copy link
Contributor Author

#48436. It was deployed to prod on 2024-09-11, the deploy comment just didn't work. Sorry for the confusion

@lschurr
Copy link
Contributor

lschurr commented Sep 20, 2024

Payment summary:

@lschurr lschurr closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suneox suneox

@lschurr lschurr

@roryabraham roryabraham

@abzokhattab abzokhattab

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@suneox @MrRefactor @lschurr @roryabraham @abzokhattab @Nodebrute