fix video does not stop playing when going to inbox from search #54552

mkzie2 · 2024-12-25T09:23:37Z

Explanation of Change

Fixed Issues

$ #54166
PROPOSAL: #54166 (comment)

Tests

Open any report and upload a video with sound
Go to Search page > Chats
Click on the video above to play

On the large screen (web/desktop)

Click on the expand button
Verify that the video continues playing instead of another video being played
Close the attachment modal
Verify that the video continues playing
Go to the inbox
Verify that the video is stopped

On the small screen (mweb/native)

After clicking on the video, verify that the video attachment modal is opened and the video is played
Close the attachment modal and verify that the video is stopped

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Open any report and upload a video with sound
Go to Search page > Chats
Click on the video above to play

On the large screen (web/desktop)

Click on the expand button
Verify that the video continues playing instead of another video being played
Close the attachment modal
Verify that the video continues playing
Go to the inbox
Verify that the video is stopped

On the small screen (mweb/native)

After clicking on the video, verify that the video attachment modal is opened and the video is played
Close the attachment modal and verify that the video is stopped

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-25.at.16.11.20.mov

Android: mWeb Chrome

Screen.Recording.2024-12-25.at.16.07.13.mov

iOS: Native

Screen.Recording.2024-12-25.at.16.13.59.mp4

iOS: mWeb Safari

Screen.Recording.2024-12-25.at.16.08.37.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-25.at.16.03.39.mov

MacOS: Desktop

Screen.Recording.2024-12-25.at.16.12.49.mp4

melvin-bot · 2024-12-25T09:26:31Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mkzie2 · 2024-12-25T09:27:08Z

The Eslint error isn't related to our changes.

suneox · 2024-12-26T13:00:58Z

The Eslint error isn't related to our changes.

Could you try to fix the ESLint issues following this guideline?

src/components/HTMLEngineProvider/HTMLRenderers/VideoRenderer.tsx

suneox · 2025-01-01T16:33:02Z

@mkzie2 After playing a video in Reports/Chats, if you navigate to a report with a posted video and play it, both videos will play simultaneously.

Could you please take a look on this issue?

Screen.Recording.2025-01-01.at.23.22.18.mp4

mkzie2 · 2025-01-03T03:12:44Z

On it today.

mkzie2 · 2025-01-08T17:02:04Z

Still investigate.

mkzie2 · 2025-01-13T09:30:49Z

@suneox I updated to fix this bug, please help to check again.

suneox · 2025-01-13T16:59:10Z

@suneox I updated to fix this bug, please help to check again.

@mkzie2 It looks like after merging with the latest main branch, we cannot play videos in reports/chat on both latest staging & current PR branch. Could you please investigate the offending PR?

Screen.Recording.2025-01-13.at.23.52.29.mp4

mkzie2 · 2025-01-17T06:29:07Z

Could you please investigate the offending PR?

I can't find the offending PR.

mkzie2 · 2025-01-23T02:55:45Z

@suneox I fixed the video play in search. Please help to check again.

suneox · 2025-01-23T05:12:48Z

@suneox I fixed the video play in search. Please help to check again.

Thanks for the update, i'll review it today

suneox · 2025-01-27T08:47:48Z

@mkzie2 Could you please check after navigate between inbox & chat report the video still playing simultaneously?

Screen.Recording.2025-01-27.at.15.44.05.mov

mkzie2 · 2025-02-03T09:34:06Z

On it now.

mkzie2 · 2025-02-07T06:24:14Z

Still finding the RCA.

mkzie2 · 2025-02-15T09:03:32Z

@suneox I updated and tested this bug above. It's fixed now.

The problem is useCurrentReportID always returns the topmost reportID now so when we from the chat go to the inbox the currentReportID from useCurrentReportID isn't changed. So now I created a way to update currentReportID used for PlaybackContext with updateCurrentPlayingReportID that will set the currentReportID to undefined if the topmost is not report top most otherwise updating it with the reportID of the top most report split navigator.

suneox · 2025-02-16T05:50:36Z

@mkzie2 Thank you for the quick update! It looks almost done. Could you please handle the control of the playing state on the video inline controller?

Screen.Recording.2025-02-16.at.12.43.41.mp4

We have a different playing state when playing from the inline controller, this issue doesn’t occur on the latest staging.

mkzie2 · 2025-02-17T08:45:10Z

@mkzie2 Thank you for the quick update! It looks almost done. Could you please handle the control of the playing state on the video inline controller?

@suneox Works well now, please help to check again.

suneox · 2025-02-17T18:37:51Z

@suneox Works well now, please help to check again.

@mkzie2 Could you please re-verify on all platforms? It looks like it doesn't work on MacOS/Safari.

Screen.Recording.2025-02-18.at.01.27.16.mp4

suneox · 2025-02-19T06:16:04Z

@mkzie2 Could you please reply to this Slack open-source thread?

mkzie2 · 2025-02-19T06:22:28Z

@suneox I'm not in Expensify Slack.

mkzie2 · 2025-02-19T18:01:25Z

@mkzie2 Could you please re-verify on all platforms? It looks like it doesn't work on MacOS/Safari.

Still finding the RCA.

mkzie2 · 2025-02-19T18:32:48Z

@suneox, I updated it to fix the error above and tested it again. Please help to check.

suneox · 2025-02-20T15:40:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-20.at.23.49.54.mp4

Android: mWeb Chrome

Screen.Recording.2025-02-20.at.22.33.11.mp4

iOS: Native

Screen.Recording.2025-02-20.at.22.27.54.mp4

iOS: mWeb Safari

Screen.Recording.2025-02-20.at.22.30.27.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-02-20.at.22.23.30.mp4

MacOS: Desktop

Screen.Recording.2025-02-20.at.22.24.28.mp4

aldo-expensify

Looking good, just a minor correction

src/components/VideoPlayerContexts/PlaybackContext.tsx

Co-authored-by: Aldo Canepa Garay <[email protected]>

mkzie2 · 2025-02-20T18:04:44Z

@aldo-expensify I Updated.

aldo-expensify · 2025-02-20T18:22:24Z

@aldo-expensify I Updated.

oops, my suggestion introduced some eslint errors, can you fix those? 🙏

mkzie2 · 2025-02-20T18:58:22Z

@aldo-expensify It's fixed.

aldo-expensify · 2025-02-20T18:59:14Z

@aldo-expensify It's fixed.

Thank you!

OSBotify · 2025-02-20T19:26:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-20T22:18:48Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.1.3-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fix video dsoe not stop playing when going to inbox from search

5bb2893

mkzie2 marked this pull request as ready for review December 25, 2024 09:26

mkzie2 requested a review from a team as a code owner December 25, 2024 09:26

melvin-bot bot requested review from suneox and removed request for a team December 25, 2024 09:26

mkzie2 mentioned this pull request Dec 25, 2024

[$250] Reports - Video sound is playing simultaneously on Reports page and full screen view #54166

Open

8 tasks

Merge branch 'main' into mkzie2-issue/54166

aa434d3

mkzie2 commented Dec 30, 2024

View reviewed changes

src/components/HTMLEngineProvider/HTMLRenderers/VideoRenderer.tsx Outdated Show resolved Hide resolved

mkzie2 changed the title ~~fix video dsoe not stop playing when going to inbox from search~~ fix video does not stop playing when going to inbox from search Jan 2, 2025

Merge branch 'main' into mkzie2-issue/54166

715ae25

mkzie2 added 2 commits January 13, 2025 16:28

fix sound bug

b5b8d6e

merge main

debbc5a

Merge branch 'main' into mkzie2-issue/54166

14c2b82

mkzie2 added 2 commits January 23, 2025 09:32

Merge branch 'main' into mkzie2-issue/54166

28af4f6

fix video play in search

74b71de

fix lint error

138d521

update current reportID for play video context

a41a5a5

mkzie2 added 2 commits February 17, 2025 15:26

Merge branch 'main' into mkzie2-issue/54166

2a955a2

remove unnecessary ref

467269a

eVoloshchak mentioned this pull request Feb 18, 2025

[$250] Android - Chat - In android, paused video starts playing when full screen mode enabled #55965

Open

8 tasks

linhvovan29546 mentioned this pull request Feb 19, 2025

When opening an attachment video in RHN from search, it loads indefinitely #57056

Open

8 tasks

Merge branch 'main' into mkzie2-issue/54166

4ed0d7d

fix error

ba50571

suneox approved these changes Feb 20, 2025

View reviewed changes

melvin-bot bot requested a review from aldo-expensify February 20, 2025 16:52

aldo-expensify requested changes Feb 20, 2025

View reviewed changes

src/components/VideoPlayerContexts/PlaybackContext.tsx Outdated Show resolved Hide resolved

Update src/components/VideoPlayerContexts/PlaybackContext.tsx

e67100e

Co-authored-by: Aldo Canepa Garay <[email protected]>

fix lint error

c7ba75b

aldo-expensify approved these changes Feb 20, 2025

View reviewed changes

aldo-expensify merged commit a4f62fa into Expensify:main Feb 20, 2025
16 checks passed

github-actions bot mentioned this pull request Feb 20, 2025

Deploy Checklist: New Expensify 2025-02-20 #57207

Open

34 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix video does not stop playing when going to inbox from search #54552

fix video does not stop playing when going to inbox from search #54552

mkzie2 commented Dec 25, 2024

melvin-bot bot commented Dec 25, 2024

mkzie2 commented Dec 25, 2024

suneox commented Dec 26, 2024

suneox commented Jan 1, 2025

mkzie2 commented Jan 3, 2025

mkzie2 commented Jan 8, 2025

mkzie2 commented Jan 13, 2025

suneox commented Jan 13, 2025

mkzie2 commented Jan 17, 2025

mkzie2 commented Jan 23, 2025

suneox commented Jan 23, 2025

suneox commented Jan 27, 2025

mkzie2 commented Feb 3, 2025

mkzie2 commented Feb 7, 2025

mkzie2 commented Feb 15, 2025

suneox commented Feb 16, 2025

mkzie2 commented Feb 17, 2025

suneox commented Feb 17, 2025

suneox commented Feb 19, 2025 •

edited

Loading

mkzie2 commented Feb 19, 2025

mkzie2 commented Feb 19, 2025

mkzie2 commented Feb 19, 2025

suneox commented Feb 20, 2025 •

edited

Loading

aldo-expensify left a comment

mkzie2 commented Feb 20, 2025

aldo-expensify commented Feb 20, 2025

mkzie2 commented Feb 20, 2025

aldo-expensify commented Feb 20, 2025

OSBotify commented Feb 20, 2025

github-actions bot commented Feb 20, 2025

fix video does not stop playing when going to inbox from search #54552

fix video does not stop playing when going to inbox from search #54552

Conversation

mkzie2 commented Dec 25, 2024

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 25, 2024

mkzie2 commented Dec 25, 2024

suneox commented Dec 26, 2024

suneox commented Jan 1, 2025

mkzie2 commented Jan 3, 2025

mkzie2 commented Jan 8, 2025

mkzie2 commented Jan 13, 2025

suneox commented Jan 13, 2025

mkzie2 commented Jan 17, 2025

mkzie2 commented Jan 23, 2025

suneox commented Jan 23, 2025

suneox commented Jan 27, 2025

mkzie2 commented Feb 3, 2025

mkzie2 commented Feb 7, 2025

mkzie2 commented Feb 15, 2025

suneox commented Feb 16, 2025

mkzie2 commented Feb 17, 2025

suneox commented Feb 17, 2025

suneox commented Feb 19, 2025 • edited Loading

mkzie2 commented Feb 19, 2025

mkzie2 commented Feb 19, 2025

mkzie2 commented Feb 19, 2025

suneox commented Feb 20, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

aldo-expensify left a comment

Choose a reason for hiding this comment

mkzie2 commented Feb 20, 2025

aldo-expensify commented Feb 20, 2025

mkzie2 commented Feb 20, 2025

aldo-expensify commented Feb 20, 2025

OSBotify commented Feb 20, 2025

github-actions bot commented Feb 20, 2025

suneox commented Feb 19, 2025 •

edited

Loading

suneox commented Feb 20, 2025 •

edited

Loading