Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-18] [$250] Report isn't showing most recent chats until refreshed #54785

Closed
1 of 8 tasks
m-natarajan opened this issue Jan 3, 2025 · 40 comments
Closed
1 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 3, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

  1. Navigate to the "Reports" section.
  2. Check for recent chats.
  3. Observe that the most recent chats are missing, even though no workspace filter is applied.

Expected Result:

All recent chats, including the most recent ones, should appear in the "Reports" view when no filters are set.

Actual Result:

Recent chats are not showing until refreshed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (2)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021876307736951387779
  • Upwork Job ID: 1876307736951387779
  • Last Price Increase: 2025-01-21
Issue OwnerCurrent Issue Owner: @mohit6789
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 3, 2025
Copy link

melvin-bot bot commented Jan 3, 2025

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
@twisterdotcom
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2025
@twisterdotcom twisterdotcom added Weekly KSv2 and removed Daily KSv2 labels Jan 6, 2025
@twisterdotcom
Copy link
Contributor

Deliverable

The deliverable is to provide reliable reproduction steps for the bug. - Follow the Propose a solution for a job process to submit the steps for review”. Inc. preconditions and additional details if they’re helpful. (ie. require x beta to be enabled, must be on a Collect plan)

@twisterdotcom twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Jan 6, 2025
@melvin-bot melvin-bot bot changed the title Report isn't showing most recent chats until refreshed [$250] Report isn't showing most recent chats until refreshed Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021876307736951387779

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 6, 2025
@twisterdotcom twisterdotcom changed the title [$250] Report isn't showing most recent chats until refreshed [$125 Reproducible Steps] Report isn't showing most recent chats until refreshed Jan 6, 2025
@huult
Copy link
Contributor

huult commented Jan 7, 2025

@twisterdotcom I am able to reproduce this issue. Can you take a look at the two videos below? Thanks!

Screen.Recording.2025-01-07.at.12.56.07.mp4
Screen.Recording.2025-01-07.at.13.03.10.mp4

@melvin-bot melvin-bot bot added the Overdue label Jan 9, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

@twisterdotcom, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

@twisterdotcom
Copy link
Contributor

Hi @huult we need just bulleted concrete recreation steps ideally on staging or production please.

Follow the Propose a solution for a job process to submit the steps for review”. Inc. preconditions and additional details if they’re helpful. (ie. require x beta to be enabled, must be on a Collect plan)

@melvin-bot melvin-bot bot removed the Overdue label Jan 10, 2025
@mohit6789
Copy link
Contributor

mohit6789 commented Jan 11, 2025

@twisterdotcom Steps to reproduced.

  • Navigate to the "Reports" section.
  • Check for recent chats.
  • Make sure you have more than 50 chats in "All chats".
  • Scroll down to the end of the "All Chat" Section".
  • Now scroll up to top of the page.
  • Change tab from "All" to "Unread" and go back to "All chat" tab.
  • Now send message from another tab.
  • Revisit the recent chat section, observe that the most recent chats are missing.

https://drive.google.com/file/d/18kG5kPzJc7GshPp1LkE403OhvRs--wlr/view?usp=sharing

I can see issues in others tabs like unread, sent etc. All issue can be fixed once we handle this issue. If this steps works for you. Please create follow up ticket to fix this issue and assign to me.

@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2025
@twisterdotcom
Copy link
Contributor

Make sure you have more than 50 chats in "All chats".

Nice. Okay, happy to pay out @mohit6789 here for the reproduction. @mohit6789 I will make it External now, please submit a proposal as normal. If we assign you, I will simply add an extra $125 bonus. If we assign somebody else, I will send a $125 through separately.

@melvin-bot melvin-bot bot removed the Overdue label Jan 13, 2025
Copy link

melvin-bot bot commented Jan 22, 2025

📣 @mohit6789 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@mohit6789
Copy link
Contributor

I will create PR before end of this week.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 25, 2025
@mohit6789
Copy link
Contributor

@allroundexperts PR is ready to review.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 11, 2025
@melvin-bot melvin-bot bot changed the title [$250] Report isn't showing most recent chats until refreshed [Due for payment 2025-02-18] [$250] Report isn't showing most recent chats until refreshed Feb 11, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 11, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 11, 2025

@allroundexperts @twisterdotcom @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Feb 17, 2025
@twisterdotcom
Copy link
Contributor

Payment due tomorrow. @allroundexperts we still need a checklist here.

@melvin-bot melvin-bot bot removed the Overdue label Feb 17, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

Payment Summary

Upwork Job

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1876307736951387779/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2025
@twisterdotcom
Copy link
Contributor

twisterdotcom commented Feb 19, 2025

@mohit6789 can you post or DM me your Upwork link please?
@allroundexperts could you complete the checklist please?

@allroundexperts
Copy link
Contributor

allroundexperts commented Feb 19, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/49192/files#r1962509928

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

  • Make sure you have more than 50 chats in "All chats".

Test:

  1. Navigate to the "Reports" section.
  2. Check for recent chats.
  3. Scroll down to the end of the "All Chat" Section".
  4. Now scroll up to top of the page.
  5. Send message from another tab.

Verify that the most recent message should be shown in few moment.

Do we agree 👍 or 👎

@mohit6789
Copy link
Contributor

@twisterdotcom here is my Upwork link https://www.upwork.com/freelancers/mohitr2

@twisterdotcom
Copy link
Contributor

Checklist completed. Payment summary updated here: #54785 (comment).

@mohit6789 please accept the offer.
@allroundexperts please request payment in newdot.

@mohit6789
Copy link
Contributor

Make sure you have more than 50 chats in "All chats".

Nice. Okay, happy to pay out @mohit6789 here for the reproduction. @mohit6789 I will make it External now, please submit a proposal as normal. If we assign you, I will simply add an extra $125 bonus. If we assign somebody else, I will send a $125 through separately.

Hi @twisterdotcom, as you mention here. Can you please add extra bonus $125 for reproduction steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants