[HOLD for payment 2025-02-24][$250] Unmask tooltip copy for Fullstory

[flaviadefaria]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected]Copy to clipboard to request to join our Slack channel!

Problem

We don't want tooltips copy to be masked

Solution

Unmask all tooltips

The contributor who works on this will need to add the fsClass="fs-unmask" property in the elements to be unmasked.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021880350559975789433
• Upwork Job ID: 1880350559975789433
• Last Price Increase: 2025-01-17
• Automatic offers:
• twilight2294 | Contributor | 105774913

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unmask tooltip copy for Fullstory

What is the root cause of that problem?

Feature request, we should add fsClass="fs-unmask to unmask the tooltip text.

What changes do you think we should make in order to solve the problem?

We need to update any of the following View element:

App/src/components/ProductTrainingContext/index.tsx

Line 185 in d50b5ae

<Text style={[styles.productTrainingTooltipText, styles.textWrap, styles.mw100]}>

App/src/components/ProductTrainingContext/index.tsx

Line 179 in d50b5ae

<View style={[styles.alignItemsCenter, styles.flexRow, styles.justifyContentCenter, styles.flexWrap, styles.textAlignCenter, styles.gap3, styles.p2]}>

We will add fsClass="fs-unmask" to the View element, like we did for the display names:

App/src/pages/home/HeaderView.tsx

Lines 230 to 231 in d50b5ae

	<View
	fsClass="fs-unmask"

if we want to unmask all the tooltips, then we need to also update the base tooltip component to include this one, but i guess here we are updating only the tooltips we get at the start of a new user

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

No tests, this is fullstory related.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021880350559975789433

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[ranjan-purbey]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Allow capturing tooltip text/copy using Fullstory by making all tooltips unmasked.

What is the root cause of that problem?

Tooltip components do not have a fs-unmask class, which is required to capture text contents of a component according to Fullstory docs.

What changes do you think we should make in order to solve the problem?

The issue can be resolved by adding a fs-unmask class to tooltip components. Since all tooltips extend BaseGenericTooltip, the class can be added to this component by default.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test that BaseGenericTooltip on render has the fs-unmask class. Since other tooltips extend this component, we probably don't need to write tests for every type of tooltip.

What alternative solutions did you explore? (Optional)

Fullstory has convenience functions to programmatically unmask elements. That approach will be beneficial if we needed to conditionally unmask some components. But in this case since we want to unmask all tooltips, using a class is a simpler and recommended solution.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @ranjan-purbey! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ranjan-purbey]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~017b42573fd7c0f12b

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[jjcoffee]

@twilight2294 was first so let's go with their proposal.

@flaviadefaria Could you confirm if literally all tooltips should be unmasked, or is it just the "product training" ones? In the former case we'd modify the base component so that all future tooltips are unmasked too.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @twilight2294 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

I'd think we want all tooltips unmasked. Can we also unmask the "nudge migration" modal that we show to users in the migration flow?

[flaviadefaria]

@flaviadefaria Could you confirm if literally all tooltips should be unmasked, or is it just the "product training" ones? In the former case we'd modify the base component so that all future tooltips are unmasked too.

Yes, all tooltips should be unmasked, and as Puneet mentioned above also the "nudge migration" modal. Thanks!

[twilight2294]

Can we also unmask the "nudge migration" modal that we show to users in the migration flow?

To understand better, which part of the migration text gets masked, can you attach a screenshot ?

[puneetlath]

[twilight2294]

Thanks, I will raise the PR today

[melvin-bot]

@puneetlath, @slafortune, @jjcoffee, @twilight2294 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twilight2294]

Working on it here

[jjcoffee]

PR under development.

[twilight2294]

Can someone put a pending payment label here ? The PR is in production from yesterday

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @slafortune, @jjcoffee, @twilight2294 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[jjcoffee]

@puneetlath Would you mind switching back to weekly so this doesn't get missed for payment 🙇