Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox/Home - No "Connect Bank Account" task #55878

Closed
1 of 8 tasks
Christinadobrzyn opened this issue Jan 28, 2025 · 17 comments
Closed
1 of 8 tasks

Inbox/Home - No "Connect Bank Account" task #55878

Christinadobrzyn opened this issue Jan 28, 2025 · 17 comments
Assignees
Labels
Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff

Comments

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Jan 28, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: current Expensify browser version
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: NA
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5505192
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/464391
Issue reported by: vincdargento
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C03UK30EA1Z/p1737997684697269

Action Performed:

  • Go to staging.expensify.com
  • Create and verify new Expensify account with Gmail address
  • Create a Control policy
  • In the task "How would you like to invite ..." Select "Manually Enter"
  • Enter another test email in the text box and click Invite
  • In the inbox task "Do you want to sync", click "No"
  • In the inbox task "How often would you like ...", select "Once a day"
  • In the inbox task "How often do reports require ...", click "Never"
  • The Inbox task "Connect bank account" should appear

Expected Result:

The task "Connect bank account" is present in the Inbox

Actual Result:

The task "Connect bank account" is missing from the Inbox

Workaround:

NA

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4
@Christinadobrzyn Christinadobrzyn self-assigned this Jan 28, 2025
@Christinadobrzyn
Copy link
Contributor Author

Christinadobrzyn commented Jan 28, 2025

Testing this again, I can see the bank account Inbox is visible after completing the steps in the OP. I'll ask QA to test this again.

Image

https://expensify.slack.com/archives/C9YU7BX5M/p1738080675837919

@mvtglobally
Copy link

mvtglobally commented Jan 28, 2025

Slightly different, but able to see the bank

Screen.Recording.2025-01-28.at.12.26.42.PM.mov

@mvtglobally
Copy link

Team is able to reproduce

https://github.com/user-attachments/assets/4ff5be79-8f39-4383-a2d8-22c8746d7ed8
https://github.com/user-attachments/assets/4dd2eb3c-7fe6-4bdd-9ed3-f08f256e2ce9

@Christinadobrzyn
Copy link
Contributor Author

Awesome, thank you @mvtglobally! Asking if callstack might have the bandwidth - https://expensify.slack.com/archives/C03UK30EA1Z/p1738110337567609?thread_ts=1737997684.697269&cid=C03UK30EA1Z

@Christinadobrzyn Christinadobrzyn added the Internal Requires API changes or must be handled by Expensify staff label Jan 30, 2025
@Christinadobrzyn
Copy link
Contributor Author

This needs to be internal

@melvin-bot melvin-bot bot added the Overdue label Feb 3, 2025
Copy link

melvin-bot bot commented Feb 3, 2025

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@flaviadefaria
Copy link
Contributor

This should go in #convert.

@Christinadobrzyn Christinadobrzyn changed the title Inbox - No "Connect Bank Account" task in Inbox Inbox - No "Connect Bank Account" task in Home Feb 4, 2025
@Christinadobrzyn Christinadobrzyn changed the title Inbox - No "Connect Bank Account" task in Home Inbox/Home - No "Connect Bank Account" task Feb 4, 2025
@Christinadobrzyn
Copy link
Contributor Author

  1. What is the expected outcome?

The task "Connect bank account" is present in the Home in Expensify Classic

  1. Why are we doing this / what value do we get out of this proposed change?

We are missing an Home task in Expensify Classic

  1. What problem are we solving?

During the onboarding process, a Home task is missing in Classic

  1. Priority and Impact

This is impacting the onboarding workflow for Control Classic users

  1. Reproduction Steps

in the OP:

  • Go to staging.expensify.com
  • Create and verify new Expensify account with Gmail address
  • Create a Control policy
  • In the task "How would you like to invite ..." Select "Manually Enter"
  • Enter another test email in the text box and click Invite
  • In the inbox task "Do you want to sync", click "No"
  • In the inbox task "How often would you like ...", select "Once a day"
  • In the inbox task "How often do reports require ...", click "Never"
  • The Inbox task "Connect bank account" should appear
  1. Estimation of how long the ticket might take to complete

Unknown - the volunteer might better know that

  1. Who has experience or domain knowledge that might help us complete it?

maybe @carlosmiceli per this Slack convo?

  1. Related Issues

Maybe this? #48591

  1. Can it be worked on by contributors or not?

I don't think so since it's classic

  1. Context for Any Existing Workarounds

Set up a business bank account on Payments page

@melvin-bot melvin-bot bot removed the Overdue label Feb 4, 2025
@Christinadobrzyn Christinadobrzyn added the Hot Pick Ready for an engineer to pick up and run with label Feb 4, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2025
@Christinadobrzyn
Copy link
Contributor Author

waiting for this to get picked up!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 7, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Christinadobrzyn
Copy link
Contributor Author

waiting for a volunteer

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 11, 2025
@Christinadobrzyn
Copy link
Contributor Author

@danielrvidal are you doing the weekly updates for the Convert channel? If yes could you add this to the weekly update to see if we can get a volunteer? TY!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 14, 2025
@Christinadobrzyn
Copy link
Contributor Author

Seeing if we can get this on a weekly update

@melvin-bot melvin-bot bot removed the Overdue label Feb 17, 2025
@Christinadobrzyn
Copy link
Contributor Author

still working on a volunteer

@Christinadobrzyn
Copy link
Contributor Author

Christinadobrzyn commented Feb 20, 2025

Testing this again - the Inbox task is showing. I think this is resolved - asking QA to test. https://expensify.slack.com/archives/C9YU7BX5M/p1740079393581879

Image

@kavimuru
Copy link

Not reproducible

Recording.440.mp4

@Christinadobrzyn
Copy link
Contributor Author

Awesome - closing this as resolved. Thanks @kavimuru!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff
Projects
Development

No branches or pull requests

4 participants