feat: update policy expense chat name #56735

nkdengineer · 2025-02-12T07:41:36Z

Explanation of Change

Update policy expense chat name to ${user's displayname}'s expense
Update the subtitle of the all rooms related to the workspace with the prefix ${policyName} • if we have multiple workspace

Fixed Issues

$ #56123
PROPOSAL: #56123 (comment)

Tests

Login with a new account
Select Manage my team in the onboarding flow and complete the flow
Notice LHN and verify that the policy expense chat name has the format ${Email upto @}'s Expenses
Change the display name to a custom display name
Go to LHN and verify that the policy expense chat name has the format ${user's displayname}'s expense
Open any chat related to the workspace and add a message or create an expense
Verify that the reports related to the workspace don't display the policy name at the prefix because we only have one workspace
Create another workspace
Notice LHN and verify that the subtitle of the reports related to the workspace has the policy name at the prefix
Go FAB > Create expense
Enter any amount > Confirmation page
Click on To field
On the participant page, verify that the subtitle of the policy expense chat has the policy name at the prefix

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Login with a new account
Select Manage my team in the onboarding flow and complete the flow
Notice LHN and verify that the policy expense chat name has the format ${Email upto @}'s Expenses
Change the display name to a custom display name
Go to LHN and verify that the policy expense chat name has the format ${user's displayname}'s expense
Open any chat related to the workspace and add a message or create an expense
Verify that the reports related to the workspace don't display the policy name at the prefix because we only have one workspace
Create another workspace
Notice LHN and verify that the subtitle of the reports related to the workspace has the policy name at the prefix
Go FAB > Create expense
Enter any amount > Confirmation page
Click on To field
On the participant page, verify that the subtitle of the policy expense chat has the policy name at the prefix

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-12.at.14.30.02.mov

Android: mWeb Chrome

Screen.Recording.2025-02-12.at.14.31.46.mov

iOS: Native

Screen.Recording.2025-02-12.at.14.30.42.mov

iOS: mWeb Safari

Screen.Recording.2025-02-12.at.14.31.30.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-12.at.14.27.56.mov

MacOS: Desktop

Screen.Recording.2025-02-12.at.14.34.32.mov

melvin-bot · 2025-02-12T08:35:44Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-02-12T13:38:19Z

src/languages/en.ts

@@ -2721,6 +2722,7 @@ const translations = {
            defaultCategory: 'Default category',
            viewTransactions: 'View transactions',
            leaveConfirmation: "Are you sure you want to leave this workspace? Once you leave, you'll lose access to all data and settings associated with this workspace.",
+            policyExpenseChatName: ({displayName}: PolicyExpenseChatNameParams) => `${displayName}'s expense`,


It should be expenses not just expense

Also, I think we want just the first name or do we want the full display name of First Lastname? cc @dannymcclain for confirmation there

Agree about expenses, and I'm pretty positive we're going with displayName in case there are multiple users with the same first name 👍

dannymcclain · 2025-02-12T14:31:12Z

Update the subtitle of the policy expense chat with the prefix ${policyName} •

Quick note about this one: we only want to do this when a user has multiple workspaces.

nkdengineer · 2025-02-13T13:47:57Z

@dannymcclain What happens if the user has two workspaces and delete one of them, and in this case what the policy expense chat name should be?

dannymcclain · 2025-02-13T14:14:26Z

What happens if the user has two workspaces and delete one of them, and in this case what the policy expense chat name should be?

I guess I would expect the little description text to go away? But cc @Expensify/design for a gut check on that one

shawnborton · 2025-02-13T14:16:25Z

That makes sense to me 👍

nkdengineer · 2025-02-13T14:50:06Z

What happens if the user has two workspaces and delete one of them, and in this case what the policy expense chat name should be?
Update the subtitle of the policy expense chat with the prefix ${policyName} •
Quick note about this one: we only want to do this when a user has multiple workspaces.

@dannymcclain Also in this case that I mentioned above, what should we display the the prefix ${policyName} •

dannymcclain · 2025-02-13T15:02:26Z

Also in this case that I mentioned above, what should we display the the prefix ${policyName} •

Would you mind rephrasing? I'm not sure I'm following. Do these mocks help clarify anything?

nkdengineer · 2025-02-13T15:13:21Z

@dannymcclain I understood the mock, the thing I need to confirm here is if we have two workspaces and we deleted one. What mock should be applied for this case? Single workspace or multiple workspace case?. The reason I asked this because when a workspace is deleted, the policy expense chat still exist.

dannymcclain · 2025-02-13T15:32:29Z

The reason I asked this because when a workspace is deleted, the policy expense chat still exist.

Ahhh I didn't realize that! Thank you for clarifying. I think in that case, where multiple exist, we should probably stick with the multi-workspace pattern and include the prepended text. Does that sound right to you @Expensify/design?

shawnborton · 2025-02-13T16:12:15Z

Hmm good question... I suppose that makes sense, though I would also expect us to append (archived) into the expense room title, so I would also be fine leaving the workspace name out if just one workspace exists.

dannymcclain · 2025-02-13T16:15:25Z

That works for me as well.

nkdengineer · 2025-02-16T18:13:24Z

Quick note about this one: we only want to do this when a user has multiple workspaces.

Updated with this expected.

nkdengineer · 2025-02-16T18:13:43Z

@fedirjh It's ready for review.

shawnborton · 2025-02-18T14:57:22Z

Oh great catches Danny!

nkdengineer · 2025-02-18T15:45:42Z

@dannymcclain For the case display Workspace, maybe because we don't have subtitle which is the personal detail of the submit to user here.

App/src/libs/ReportUtils.ts

Lines 4601 to 4611 in e66ec9a

    
           if ((isPolicyExpenseChat(report) && !!report?.isOwnPolicyExpenseChat) || isExpenseReport(report)) { 
        
               const submitToAccountID = getSubmitToAccountID(getPolicy(report?.policyID), report); 
        
               const submitsToAccountDetails = allPersonalDetails?.[submitToAccountID]; 
        
               const subtitle = submitsToAccountDetails?.displayName ?? submitsToAccountDetails?.login; 
        
               if (!subtitle || !config.isCreateExpenseFlow) { 
        
                   return translateLocal('workspace.common.workspace'); 
        
               } 
        
               return translateLocal('iou.submitsTo', {name: subtitle ?? ''}); 
        
           }

trjExpensify · 2025-02-18T17:09:43Z

Did we decide if we wanted to change the subtext here from Workspace to be something like Expense room? I can't remember if we landed on anything,

I think the workspace name would be most useful here probably.

nkdengineer · 2025-02-19T16:23:14Z

@dannymcclain The display in Search router is fixed now.

shawnborton · 2025-02-19T23:26:36Z

@nkdengineer did you address our feedback above about using the Workspace name instead of just "Workspace" here?

nkdengineer · 2025-02-20T09:33:22Z

@shawnborton I just updated.

dannymcclain · 2025-02-20T14:00:15Z

Going to run another test build

github-actions · 2025-02-20T14:00:52Z

🚧 @dannymcclain has triggered a test build. You can view the workflow run here.

github-actions · 2025-02-20T14:27:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56735/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56735/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56735/NewExpensify.dmg	https://56735.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dannymcclain · 2025-02-20T14:32:24Z

Nice! Feeling pretty good to me.

shawnborton · 2025-02-20T15:15:54Z

Yeah, same! I say let's get this into final review @fedirjh

nkdengineer · 2025-02-20T15:21:45Z

tests/unit/OptionsListUtilsTest.ts

            });

            expect(canCreate).toBe(false);
        });
    });

-    it('createOptionList() localization', () => {


@fedirjh Just a note here: I deleted this localization test because it's outdated now, we will show Workspace's name instead of Workspace work.

can we have a test for expenses room localization ?

@fedirjh I updated.

fedirjh

Looks solid. left small review.

fedirjh · 2025-02-20T16:39:43Z

tests/unit/OptionsListUtilsTest.ts

            });

            expect(canCreate).toBe(false);
        });
    });

-    it('createOptionList() localization', () => {


can we have a test for expenses room localization ?

fedirjh · 2025-02-20T19:05:45Z

src/libs/ReportUtils.ts

-    if (report?.isOwnPolicyExpenseChat) {
-        return getPolicyName({report, policy, policies, reports});
-    }


Why don't keep old behavior and early return at this point ?

@fedirjh What do you mean?

I saw that you moved this early return to the bottom of the function. I suggested to keep the early return to avoid any extra calculation.

fedirjh · 2025-02-20T19:10:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

fedirjh · 2025-02-20T19:21:53Z

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

fedirjh · 2025-02-20T20:03:23Z

@shawnborton @dannymcclain Just noticed that when you have many workspaces and you select one , the workspace prefix is still applied to its rooms. should we keep it that way ?

fedirjh · 2025-02-20T20:21:22Z

Unavailable workspace is displayed for some public rooms, is that expected ?

dannymcclain · 2025-02-20T20:25:08Z

Just noticed that when you have many workspaces and you select one , the workspace prefix is still applied to its rooms. should we keep it that way ?

Ooh great question. I don't think I have very strong feelings about this—I could honestly go either way. I guess it makes sense to remove it when filtered to a workspace, but at the same time it doesn't really bother me. @Expensify/design what about you all?

dubielzyk-expensify · 2025-02-21T00:52:25Z

Yeah same, I could go either way. Part of me prefers the simplification, but I also just feel like while still are things evolving we're just adding complexity, so I think I lean on just keeping the workspace appended regardless of whether you have filtered a workspace or not.

nkdengineer · 2025-02-21T08:41:22Z

Unavailable workspace is displayed for some public rooms, is that expected ?

Updated to fix this case.

dannymcclain · 2025-02-21T13:54:40Z

Yeah that's a good point. Probably no need to add the extra complexity right now. If we find that this pattern sticks around for the long haul, we can do a follow up to perfectly perfect it. 👍

shawnborton · 2025-02-21T13:56:11Z

Yeah, I can totally get down with that too. Then we can get some real world usage and see how it goes. I don't think many people even use the workspace filter IMO so I don't think it's the biggest deal anyways.

nkdengineer added 3 commits February 12, 2025 14:35

feat: update policy expense chat name

0dcb964

fix lint

400294a

fix test

e4b868b

nkdengineer marked this pull request as ready for review February 12, 2025 08:35

nkdengineer requested a review from a team as a code owner February 12, 2025 08:35

melvin-bot bot requested review from fedirjh and removed request for a team February 12, 2025 08:35

shawnborton reviewed Feb 12, 2025

View reviewed changes

nkdengineer added 2 commits February 13, 2025 20:44

merge main

e30e9e9

update translation

e246265

nkdengineer added 2 commits February 13, 2025 20:51

update test

89d4d53

update test

25a9355

nkdengineer added 5 commits February 17, 2025 00:03

only display prefix for multiple workspaces

3982dc6

Merge branch 'main' into fix/56123

f693dd9

update test

1ee2938

fix test

47639de

add correct test daat

ce1437f

display prefix in the search router

836df81

remove log

2742164

Merge branch 'main' into fix/56123

e538e32

nkdengineer added 2 commits February 20, 2025 16:27

Merge branch 'main' into fix/56123

3b7fed1

replace workspace subtile to workspace name

f225a80

update test

2b49f9b

nkdengineer commented Feb 20, 2025

View reviewed changes

fedirjh reviewed Feb 20, 2025

View reviewed changes

nkdengineer added 2 commits February 21, 2025 14:43

Merge branch 'main' into fix/56123

e03edb9

update test and fix the case public room

60497b4

feat: update policy expense chat name #56735

Are you sure you want to change the base?

feat: update policy expense chat name #56735

Conversation

nkdengineer commented Feb 12, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 12, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dannymcclain commented Feb 12, 2025

nkdengineer commented Feb 13, 2025

dannymcclain commented Feb 13, 2025

shawnborton commented Feb 13, 2025

nkdengineer commented Feb 13, 2025

dannymcclain commented Feb 13, 2025

nkdengineer commented Feb 13, 2025

dannymcclain commented Feb 13, 2025

shawnborton commented Feb 13, 2025

dannymcclain commented Feb 13, 2025

nkdengineer commented Feb 16, 2025

nkdengineer commented Feb 16, 2025

shawnborton commented Feb 18, 2025

nkdengineer commented Feb 18, 2025 • edited Loading

trjExpensify commented Feb 18, 2025

nkdengineer commented Feb 19, 2025

shawnborton commented Feb 19, 2025

nkdengineer commented Feb 20, 2025

dannymcclain commented Feb 20, 2025

github-actions bot commented Feb 20, 2025

github-actions bot commented Feb 20, 2025

dannymcclain commented Feb 20, 2025

shawnborton commented Feb 20, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedirjh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedirjh commented Feb 20, 2025 • edited Loading

Reviewer Checklist

fedirjh commented Feb 20, 2025 • edited Loading

Screenshots/Videos

fedirjh commented Feb 20, 2025

fedirjh commented Feb 20, 2025

dannymcclain commented Feb 20, 2025

dubielzyk-expensify commented Feb 21, 2025

nkdengineer commented Feb 21, 2025

dannymcclain commented Feb 21, 2025

shawnborton commented Feb 21, 2025

nkdengineer commented Feb 12, 2025 •

edited

Loading

nkdengineer commented Feb 18, 2025 •

edited

Loading

fedirjh commented Feb 20, 2025 •

edited

Loading

fedirjh commented Feb 20, 2025 •

edited

Loading