Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-27] [$500] Update default Reports page filters #56785

Open
puneetlath opened this issue Feb 12, 2025 · 19 comments
Open
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Feb 12, 2025

We would like to make the following changes to the default filters on the Reports page:

  1. Stop using group-by:report on the “Expenses” default filter. Meaning, if you click “Draft” or "Outstanding" for example, that’s just a list of expenses that are on draft reports. Instead of grouped by Report as they are today.
Image
  1. Introduce a “Expense Reports” default to the Reports page LHN which is grouped by report across statuses, including All.

This should all be possible simply by updating the search queries that are used by the default filters on the page.

Discussed here: https://expensify.slack.com/archives/C07NMDKEFMH/p1738888571782459?thread_ts=1738870360.205669&cid=C07NMDKEFMH

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892701968151064892
  • Upwork Job ID: 1892701968151064892
  • Last Price Increase: 2025-02-20
@puneetlath puneetlath added the NewFeature Something to build that is a new item. label Feb 12, 2025
@puneetlath puneetlath self-assigned this Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@puneetlath
Copy link
Contributor Author

@shawnborton what icon should we use for the expense reports in the Reports page LHN?

Image

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 14, 2025
@ishpaul777
Copy link
Contributor

video for actual page, we need icon for the top header as well

413313619-ca3abc3a-d44b-4f60-a915-9c1a3d2527e9.mov

@shawnborton
Copy link
Contributor

Soon we're going to make it so that the query bar always shows on every page, so we won't need any fancy icon for the top of the page. See here for more, #56326

As for the icon in the LHN, you can use our document.svg icon

But actually, do you mind uploading a new document icon (it's slightly skinnier) and using that instead? You can directly overwrite the existing document.svg file so it updates everywhere: document.svg.zip cc @Expensify/design for viz

@puneetlath do we want to call this Expense Reports or just Reports?

@trjExpensify
Copy link
Contributor

I think Expense reports because they're only of type:expense.

@shawnborton
Copy link
Contributor

Cool, works for me!

@ishpaul777
Copy link
Contributor

But actually, do you mind uploading a new document icon (it's slightly skinnier) and using that instead? You can directly overwrite the existing document.svg file so it updates everywhere: document.svg.zip cc @Expensify/design for viz

done 👍

Image

@shawnborton
Copy link
Contributor

Lovely!

@flaviadefaria flaviadefaria moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Feb 18, 2025
@ZhenjaHorbach
Copy link
Contributor

@puneetlath @jliexpensify
Could you assign me here since I reviewed this PR, please ?

@puneetlath puneetlath changed the title Update default Reports page filters [$500] Update default Reports page filters Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

Copy link

melvin-bot bot commented Feb 20, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title [$500] Update default Reports page filters [Due for payment 2025-02-27] [$500] Update default Reports page filters Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 20, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ZhenjaHorbach / @ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@jliexpensify jliexpensify added the External Added to denote the issue can be worked on by a contributor label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021892701968151064892

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Current assignees @ZhenjaHorbach and @ishpaul777 are eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 20, 2025
@jliexpensify
Copy link
Contributor

Payment Summary:

https://www.upwork.com/jobs/~021892701968151064892

LMK if this is incorrect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
Status: Second Cohort - CRITICAL
Development

No branches or pull requests

6 participants