Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-27] mWeb - Invoices - The back button doesn't correspond in the invoice tab on the search page #57157

Open
1 of 8 tasks
IuliiaHerets opened this issue Feb 20, 2025 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 20, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: iPhone 13 / 18.2.1 / Safari
App Component: Search

Action Performed:

  1. Navigate to https://staging.new.expensify.com
    2.Enable invoices in the WS
    3.Submit at least 2 invoices
    4.Navigate to the Reports page
    5.Click on invoices
  2. Tap on the back button

Expected Result:

After tapping the back button, the select option closes and the invoice tab is opened

Actual Result:

The select option is selected automatically. The back button doesn't correspond in the invoice tab on the search page

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6748676_1740029932630.ScreenRecording_02-20-2025_00-32-30_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 20, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Feb 20, 2025

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 20, 2025
@IuliiaHerets IuliiaHerets changed the title mWeb - Invoices - mWeb- The back button doesn't correspond in the invoice tab on the search page mWeb - Invoices - The back button doesn't correspond in the invoice tab on the search page Feb 20, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 20, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Prod behaviour

ScreenRecording_02-20-2025.01-36-27_1.1.mp4

@Kicu
Copy link
Member

Kicu commented Feb 20, 2025

I work for SWM and I can look into this, since this is most likely a regression after either bottom bar navigation PR or Search PR
CC @mountiny

@mountiny
Copy link
Contributor

@Kicu it is a deploy blocker so some changes from the checklist in staging must have triggered this

@NikkiWines
Copy link
Contributor

NikkiWines commented Feb 20, 2025

Seems most likely that this would be caused by changes in #56204 Nope, that wasn't it

@NikkiWines
Copy link
Contributor

NikkiWines commented Feb 20, 2025

I was able to repro on dev, and actually, I take back what I said about it being the PR above. It looks like it was #56850. Reverting that PR locally resolves the issue

cc: @ishpaul777 @puneetlath @ZhenjaHorbach

Pinged in slack here as well.

@Kicu
Copy link
Member

Kicu commented Feb 20, 2025

yes, I have done some digging using git bisect and I can confirm that specifically commit 69be62a563e78afbf1e7073342502a38363a7141 is the first bad commit.

mateusz@~/swmansion/projects/expensify-app-fork % git bisect bad
69be62a563e78afbf1e7073342502a38363a7141 is the first bad commit
commit 69be62a563e78afbf1e7073342502a38363a7141
Author: Ishpaul Singh <[email protected]>
Date:   Fri Feb 14 01:04:24 2025 +0530

    Add grouping by reports functionality in search components

CC @luacmartins for visibility

Also related topic - on the video for repro on this issue we can see the non-closing popover modal, which is completely separate issue. I will drop an issue link here later, to avoid any confusion.

@ZhenjaHorbach
Copy link
Contributor

Also related topic - on the video for repro on this issue we can see the non-closing popover modal, which is completely separate issue. I will drop an issue link here later, to avoid any confusion.

About this
When we press go back with a broken modal
Selected button disappears

2025-02-20.16.04.43.mov

@Kicu
Copy link
Member

Kicu commented Feb 20, 2025

When we press go back with a broken modal
Selected button disappears

well... that is new 😅 did not notice that before. We probably need a separate issue for this? and to verify on which platforms it reproduces.

@francoisl
Copy link
Contributor

The fix is working on staging, removing the blocker label

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Feb 20, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title mWeb - Invoices - The back button doesn't correspond in the invoice tab on the search page [Due for payment 2025-02-27] mWeb - Invoices - The back button doesn't correspond in the invoice tab on the search page Feb 20, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

  • @Kicu does not require payment (Contractor)

Copy link

melvin-bot bot commented Feb 20, 2025

@NikkiWines @joekaufmanexpensify @Kicu The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants