-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Due for payment 2025-02-27] mWeb - Invoices - The back button doesn't correspond in the invoice tab on the search page #57157
Comments
Triggered auto assignment to @NikkiWines ( |
💬 A slack conversation has been started in #expensify-open-source |
Triggered auto assignment to @joekaufmanexpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Prod behaviour ScreenRecording_02-20-2025.01-36-27_1.1.mp4 |
I work for SWM and I can look into this, since this is most likely a regression after either bottom bar navigation PR or Search PR |
@Kicu it is a deploy blocker so some changes from the checklist in staging must have triggered this |
|
I was able to repro on dev, and actually, I take back what I said about it being the PR above. It looks like it was #56850. Reverting that PR locally resolves the issue cc: @ishpaul777 @puneetlath @ZhenjaHorbach Pinged in slack here as well. |
yes, I have done some digging using
CC @luacmartins for visibility Also related topic - on the video for repro on this issue we can see the non-closing popover modal, which is completely separate issue. I will drop an issue link here later, to avoid any confusion. |
About this 2025-02-20.16.04.43.mov |
well... that is new 😅 did not notice that before. We probably need a separate issue for this? and to verify on which platforms it reproduces. |
The fix is working on staging, removing the blocker label |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-27. 🎊 For reference, here are some details about the assignees on this issue:
|
@NikkiWines @joekaufmanexpensify @Kicu The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: iPhone 13 / 18.2.1 / Safari
App Component: Search
Action Performed:
2.Enable invoices in the WS
3.Submit at least 2 invoices
4.Navigate to the Reports page
5.Click on invoices
Expected Result:
After tapping the back button, the select option closes and the invoice tab is opened
Actual Result:
The select option is selected automatically. The back button doesn't correspond in the invoice tab on the search page
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6748676_1740029932630.ScreenRecording_02-20-2025_00-32-30_1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @joekaufmanexpensifyThe text was updated successfully, but these errors were encountered: