Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Update logic around showing loading skeletons #57174

Open
mountiny opened this issue Feb 20, 2025 · 4 comments
Open

[$250] Update logic around showing loading skeletons #57174

mountiny opened this issue Feb 20, 2025 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

mountiny commented Feb 20, 2025

Background:

Currently, the app uses loading indicators (skeletons and loading bars) to show when data is being retrieved. The loading states were originally implemented to provide visual feedback during data fetching operations.

Problem:

We currently often land in the infinite loading state. When the app displays loading indicators at inappropriate times (such as when no data is being fetched), it causes user confusion and perceived performance issues, which results in unnecessary wait times and degraded user experience.

There are three specific scenarios to focus on:

  • Chat with completely missing message history (no report actions)
  • Chat with only the latest message visible (1 report action)
  • Simultaneous infinite loaders appearing on both LHN and report view (no reports & report actions)

Solution:

Improve the cases highlighted above so that we do not show the loader when we do not fetch data

@adhorodyski

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021892553675068649789
  • Upwork Job ID: 1892553675068649789
  • Last Price Increase: 2025-02-20
Issue OwnerCurrent Issue Owner: @fedirjh
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 20, 2025
@mountiny mountiny self-assigned this Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 20, 2025
@martasudol
Copy link

martasudol commented Feb 20, 2025

Hi, Marta from Callstack here. Please assign me to this ticket - I've created PR in #56819

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Feb 20, 2025
@melvin-bot melvin-bot bot changed the title Update logic around showing loading skeletons [$250] Update logic around showing loading skeletons Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021892553675068649789

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 20, 2025
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
Status: No status
Development

No branches or pull requests

4 participants