[$2000] iOS app - Attachment - User can't see PDF preview before uploading #7962

kbecciv · 2022-03-02T03:13:10Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open the New Expensify Beta app
Sign into a valid user account (High Traffic or Low)
Navigate to any conversation
Tap on the "Plus" signal
Tap on "Add Attachment"
Tap on "Choose Document" and select any PDF document

Expected Result:

The user expects to be able to see the preview of the PDF before uploading

Actual Result:

The user is not able to see the preview of his/her PDF. The document loads as a grey page and can only be seen within the chat history after being sent.

Workaround:

Unknow

Platform:

Where is this issue occurring?

iOS

Version Number: 1.1.41.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): [email protected]

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5475042_Can_t_See_Preview_.mp4

Bug5475042_PDF_that_can_t_be_seen.pdf

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

MelvinBot · 2022-03-02T03:13:13Z

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

MelvinBot · 2022-03-02T16:43:30Z

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Christinadobrzyn · 2022-03-04T03:55:24Z

looks like it might be related to this GH - #7365 - that is closed.

Christinadobrzyn · 2022-03-04T03:57:38Z

Created Upwork Job
Internal posting - https://www.upwork.com/ab/applicants/1499594733421305856/job-details
External posting - https://www.upwork.com/jobs/~0109a0f58059e7df27

MelvinBot · 2022-03-04T03:57:49Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

MelvinBot · 2022-03-04T03:57:52Z

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Christinadobrzyn · 2022-03-11T03:34:49Z

Price increase $500!

barun1997 · 2022-03-11T12:13:05Z

Hi, I just reproduced this bug and found the root cause.

It is to do with the file name. I tried uploading a PDF with a space in its name, and it didn't show me a preview. (case in point, first video).

This is because of the sourceURL that is given to PDFViewer (

App/src/components/PDFView/index.native.js

Lines 34 to 37 in c26e415

    
           <TouchableWithoutFeedback style={[styles.flex1, props.style]}> 
        
               <PDF 
        
                   activityIndicator={<FullScreenLoadingIndicator />} 
        
                   source={{uri: props.sourceURL}}

): file:///.../sample%20file.pdf

And there is an error loading the file with that URL. We will need to find a way to replace that %20 into a space, like this: /sample file.pdf.

This can be as easy as replacing props.sourceURL using: props.sourceURL.replace("%20", " ") for iOS.

The second video shows my solution works.

Simulator.Screen.Recording.-.iPhone.13.-.2022-03-11.at.17.47.34.mp4

This.is.new.mov

parasharrajat · 2022-03-11T13:48:33Z

Nice catch @barun1997. Could you please use decodeURIComponent for this purpose?

I like @barun1997's proposal. Let's go with it.

cc: @roryabraham

🎀 👀 🎀 C+ reviewed

barun1997 · 2022-03-11T14:14:30Z

@parasharrajat yup will do!

barun1997 · 2022-03-14T10:29:11Z

Hi guys, should I start working on this?

parasharrajat · 2022-03-14T10:48:38Z

Did you get a chance to look at the Contribution.md guidelines? Maybe that helps. In short, you will be assigned to this issue before you can start. Also hired on Upwork.

roryabraham · 2022-03-15T19:41:57Z

Thanks for the investigation @barun1997, your proposal looks good to me 👍

MelvinBot · 2022-03-15T19:42:07Z

📣 @barun1997 You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Christinadobrzyn · 2022-03-16T02:12:58Z

Hired @barun1997 in Upwork for the fix and @parasharrajat as the C+

gadhiyamanan · 2022-08-25T11:36:43Z

ok. i think PR deployed to production and right now regression period is going on, correct me if I am wrong.

cc: @roryabraham @kadiealexander

kadiealexander · 2022-08-25T11:46:42Z

@gadhiyamanan, could you please link me to the PR? There are quite a few in the hundreds of messages in this issue so I'd like to make sure it's the right one.

gadhiyamanan · 2022-08-25T11:50:22Z

Please check this PR #9841

cc: @roryabraham @kadiealexander

kadiealexander · 2022-08-25T11:56:21Z

Thank you! The PR is not yet deployed to staging or production because QA is still happening as per this comment:

gadhiyamanan · 2022-08-25T12:59:29Z

I think PR deployed as per list

cc: @roryabraham @kadiealexander

roryabraham · 2022-08-25T13:33:33Z

Hi @gadhiyamanan, this PR was merged to the production branch two days ago: #10495, but due to deploy issues, it was not deployed to production. We are working hard to try and get a new release out. Thanks for your patience.

roryabraham · 2022-08-29T14:08:27Z

This PR is in production now, was deployed in 1.1.89-4, 4 days ago. https://github.com/Expensify/App/actions/runs/2928185961

mvtglobally · 2022-08-30T15:17:55Z

Issue not reproducible during KI retests. (Second week)

kadiealexander · 2022-09-01T16:13:03Z

https://www.upwork.com/ab/applicants/1499594733421305856/job-details
https://www.upwork.com/jobs/~0109a0f58059e7df27

@gadhiyamanan @parasharrajat please accept the contract I just sent and I'll get this paid out for you both :)

gadhiyamanan · 2022-09-01T16:27:00Z

@kadiealexander accepted.

gadhiyamanan · 2022-09-02T15:44:49Z

@kadiealexander ping for upwork

kadiealexander · 2022-09-02T15:49:31Z

Payment was made yesterday, is there an issue?

melvin-bot · 2022-09-02T15:49:53Z

@roryabraham @kadiealexander Be sure to fill out the Contact List!

gadhiyamanan · 2022-09-02T15:57:34Z

@kadiealexander I think you sent an offer but payment is pending, can you check ?

cc: @roryabraham

gadhiyamanan · 2022-09-05T17:31:16Z

@kadiealexander I think you sent an offer but payment is pending, can you check ?

@kadiealexander have you checked?

cc : @roryabraham @parasharrajat

parasharrajat · 2022-09-05T19:43:35Z

Yeah, payment is pending for me too. @kadiealexander

kadiealexander · 2022-09-06T08:47:57Z

Strange, for me it is showing that the contracts were ended by you both. I'll reissue a new contract for you both now and once you've accepted I'll issue payment. Sorry for the confusion here!

kadiealexander · 2022-09-07T11:25:40Z

@parasharrajat - all paid, thank you!
@gadhiyamanan - please accept the contract at your earliest convenience :)

gadhiyamanan · 2022-09-07T11:28:25Z

@kadiealexander accepted, should i end the first contact?

parasharrajat · 2022-09-07T12:35:53Z

Yeah, cancel the contract and I will do the same. You can also paste the link here.

@kadiealexander This is the job URL for the first contract https://www.upwork.com/jobs/iOS-app-User-can-see-PDF-preview-when-uploading-attachment-Expensify-7962_~0139a6e40732d704a3.

gadhiyamanan · 2022-09-08T12:20:05Z

@kadiealexander ping for upwork

kadiealexander · 2022-09-08T12:36:08Z

Thanks @gadhiyamanan, I think everyone is paid and all contracts are ended. Please let me know if there's anything outstanding!

melvin-bot · 2022-09-08T12:36:11Z

@roryabraham @kadiealexander Be sure to fill out the Contact List!

gadhiyamanan · 2022-09-08T12:36:16Z

Thank You :)

kbecciv added Engineering Daily KSv2 labels Mar 2, 2022

MelvinBot assigned TomatoToaster Mar 2, 2022

TomatoToaster removed their assignment Mar 2, 2022

TomatoToaster added the External Added to denote the issue can be worked on by a contributor label Mar 2, 2022

MelvinBot assigned Christinadobrzyn Mar 2, 2022

Christinadobrzyn added the Exported label Mar 4, 2022

botify removed the Daily KSv2 label Mar 4, 2022

MelvinBot added the Weekly KSv2 label Mar 4, 2022

MelvinBot assigned parasharrajat Mar 4, 2022

MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 4, 2022

MelvinBot assigned roryabraham Mar 4, 2022

roryabraham assigned barun1997 Mar 15, 2022

MelvinBot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 15, 2022

Christinadobrzyn changed the title ~~iOS app - Attachment - User can't see PDF preview before uploading~~ [$500] iOS app - Attachment - User can't see PDF preview before uploading Mar 16, 2022

melvin-bot bot mentioned this issue Aug 25, 2022

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed

kadiealexander added Daily KSv2 and removed Weekly KSv2 labels Sep 1, 2022

kadiealexander closed this as completed Sep 2, 2022

kadiealexander reopened this Sep 6, 2022

kadiealexander closed this as completed Sep 8, 2022

[$2000] iOS app - Attachment - User can't see PDF preview before uploading #7962

[$2000] iOS app - Attachment - User can't see PDF preview before uploading #7962

Comments

kbecciv commented Mar 2, 2022

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

MelvinBot commented Mar 2, 2022

MelvinBot commented Mar 2, 2022

Christinadobrzyn commented Mar 4, 2022

Christinadobrzyn commented Mar 4, 2022

MelvinBot commented Mar 4, 2022

MelvinBot commented Mar 4, 2022

Christinadobrzyn commented Mar 11, 2022

barun1997 commented Mar 11, 2022

parasharrajat commented Mar 11, 2022

barun1997 commented Mar 11, 2022

barun1997 commented Mar 14, 2022

parasharrajat commented Mar 14, 2022

roryabraham commented Mar 15, 2022

MelvinBot commented Mar 15, 2022

Christinadobrzyn commented Mar 16, 2022

gadhiyamanan commented Aug 25, 2022 • edited Loading

kadiealexander commented Aug 25, 2022

gadhiyamanan commented Aug 25, 2022 • edited Loading

kadiealexander commented Aug 25, 2022 • edited Loading

gadhiyamanan commented Aug 25, 2022 • edited Loading

roryabraham commented Aug 25, 2022

roryabraham commented Aug 29, 2022

mvtglobally commented Aug 30, 2022

kadiealexander commented Sep 1, 2022

gadhiyamanan commented Sep 1, 2022

gadhiyamanan commented Sep 2, 2022

kadiealexander commented Sep 2, 2022

melvin-bot bot commented Sep 2, 2022

gadhiyamanan commented Sep 2, 2022 • edited Loading

gadhiyamanan commented Sep 5, 2022 • edited Loading

parasharrajat commented Sep 5, 2022

kadiealexander commented Sep 6, 2022 • edited Loading

kadiealexander commented Sep 7, 2022

gadhiyamanan commented Sep 7, 2022 • edited Loading

parasharrajat commented Sep 7, 2022 • edited Loading

gadhiyamanan commented Sep 8, 2022 • edited Loading

kadiealexander commented Sep 8, 2022

melvin-bot bot commented Sep 8, 2022

gadhiyamanan commented Sep 8, 2022

gadhiyamanan commented Aug 25, 2022 •

edited

Loading

gadhiyamanan commented Aug 25, 2022 •

edited

Loading

kadiealexander commented Aug 25, 2022 •

edited

Loading

gadhiyamanan commented Aug 25, 2022 •

edited

Loading

gadhiyamanan commented Sep 2, 2022 •

edited

Loading

gadhiyamanan commented Sep 5, 2022 •

edited

Loading

kadiealexander commented Sep 6, 2022 •

edited

Loading

gadhiyamanan commented Sep 7, 2022 •

edited

Loading

parasharrajat commented Sep 7, 2022 •

edited

Loading

gadhiyamanan commented Sep 8, 2022 •

edited

Loading