Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding New Brushes to Build Process #30

Closed
wants to merge 2 commits into from
Closed

Adding New Brushes to Build Process #30

wants to merge 2 commits into from

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Jun 11, 2024

Closes #29

Build process works and added the extra files https://github.com/MrRowey/FAForeverMapEditor/actions/runs/9463405473

@MrRowey MrRowey requested a review from Garanas June 11, 2024 10:15
@Garanas
Copy link
Member

Garanas commented Jun 11, 2024

I'm wondering (from a security point of view) whether it is not best to add the repository as a submodule. That way you can stick to a specific commit. It provides you a way to preview the content of the submodule before updating it. Otherwise whatever is on the master branch of the repository you're including would become part of this build 🤔

@MrRowey
Copy link
Member Author

MrRowey commented Jun 11, 2024

Cherry pick a spesific commit version ?

@MrRowey
Copy link
Member Author

MrRowey commented Jun 11, 2024

would we be better off then forking that repo in the faf org that way is only updated by the faf org ?

@Garanas
Copy link
Member

Garanas commented Jun 11, 2024

I don't know, @Sheikah45 what are your thoughts on this?

@Sheikah45
Copy link
Member

Either a submodule or just actually add the brushes to this repo. Checking out another uncontrolled repo isn't really good practice

@MrRowey MrRowey marked this pull request as draft June 12, 2024 09:33
@MrRowey MrRowey closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in CaptinKlutz TerrainBrushes in Build Process
3 participants