-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite order mapper needs to remove invalid characters from PO Numbers #771
Comments
@banerjek My concern would be that this could result in value collisions. My inclination would be to log them as failed in the data issues log and indicate "invalid characters in po number". |
That would work -- anything that makes it clear why orders fail is good. So far, all the situations where this has been an issue were spaces and punctuation (i.e.more there for cosmetic reasons than part of PO -- including variable syntax for polines attached to the same PO). I should probably look at a lot more data to figure out the collision risk |
I have started working on this issue |
@ealexch Just seeing this, and had a look at your branch. As mentioned above, I'm not entirely sure that the basic sanitization approach is appropriate here without some additional overhaul to flag potential duplicates and populate a data issues log. |
Any character that doesn't match [A-Zaz0-9] should be stripped from PO Numbers -- otherwise won't load
The text was updated successfully, but these errors were encountered: