Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Dune buildsystem #139

Closed
XVilka opened this issue Jun 26, 2019 · 2 comments · Fixed by #212
Closed

Switch to Dune buildsystem #139

XVilka opened this issue Jun 26, 2019 · 2 comments · Fixed by #212

Comments

@XVilka
Copy link
Contributor

XVilka commented Jun 26, 2019

Will improve modular building experience and speed.
And pure ocamlbuild is being deprecated slowly in OCamlverse. It will make building on Windows platforms easier as well.

https://dune.readthedocs.io/en/latest/

@msprotz
Copy link
Contributor

msprotz commented Jun 26, 2019

Hi XVilka,

Thanks for the bug report! A few points to keep in mind:

  • unless ocamlbuild breaks in a catastrophic manner, it's unlikely that I'll find cycles to upgrade the build system
  • kremlin is part of the larger everest project, and every change in tooling incurs debugging, upgrades, and general pain for the variety of users and setups that we have
  • we are committed to the mingw toolchain on windows, executed from a cygwin environment -- any switch to Dune would absolutely have to be compatible with that environment.

As such, I'm reluctant to undertake an effort now to switch to Dune, as it's likely to incur a lot of build complications. If you're willing to submit a pull request, I may be convinced to give it a go and try things out on CI and with other users? I would need your help when peoples' setups break and we need to debug what's going astray.

Thanks,

Jonathan

@XVilka
Copy link
Contributor Author

XVilka commented Jun 26, 2019

I will check, it shouldn't be hard.

@tahina-pro tahina-pro linked a pull request Jan 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants