Light component only takes green channel

[Tropingenie]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

Using the light component, and sending it (255,0,0) to the set colour pin, I noticed they were appearing "black." I quickly made a test setup using only a light and memory, and reproduced.

Reproduction steps

1. Start the editor, place a hull, shell, light component, and memory component (optionally more lighting and oxygenite shards)
2. Link the signal_out of the memory to the set_color of the light
3. Play in editor, and set the memory to (255,0,0)
4. Click on the light, observe it says (0,0,0)
5. Set to (255,255,0)
6. Observe light says (0,255,0)
7. Repeat for any other values in any color channel. Light will only update green.

Bug prevalence

Happens every time I play

Single player or multiplayer?

Other

-

In editor

Version

v1.7.7.0 (Winter Update)

-

No response

Which operating system did you encounter this bug on?

Linux

Relevant error messages and crash reports

No response

[SomeRandomNoobKekeke]

Just don't use brackets

It seems to be using this monstrosity to parse color

Barotrauma/Barotrauma/BarotraumaShared/SharedSource/Serialization/XMLExtensions.cs

Lines 885 to 996 in 8f0d89a

	public static Color ParseColor(string stringColor, bool errorMessages = true)
	{
	if (stringColor.StartsWith("gui.", StringComparison.OrdinalIgnoreCase))
	{
	#if CLIENT
	Identifier colorName = stringColor.Substring(4).ToIdentifier();
	if (GUIStyle.Colors.TryGetValue(colorName, out GUIColor guiColor))
	{
	return guiColor.Value;
	}
	#endif
	return Color.White;
	}
	if (stringColor.StartsWith("faction.", StringComparison.OrdinalIgnoreCase))
	{
	Identifier factionId = stringColor.Substring(8).ToIdentifier();
	if (FactionPrefab.Prefabs.TryGet(factionId, out var faction))
	{
	return faction.IconColor;
	}
	return Color.White;
	}
	if (monoGameColors.TryGetValue(stringColor.ToIdentifier(), out var monoGameColor))
	{
	return monoGameColor;
	}
	string[] strComponents = stringColor.Split(',');
	Color color = Color.White;
	float[] components = new float[4] { 1.0f, 1.0f, 1.0f, 1.0f };
	if (strComponents.Length == 1)
	{
	bool altParseFailed = true;
	stringColor = stringColor.Trim();
	if (stringColor.Length > 0 && stringColor[0] == '#')
	{
	stringColor = stringColor.Substring(1);
	if (int.TryParse(stringColor, NumberStyles.HexNumber, CultureInfo.InvariantCulture, out int colorInt))
	{
	if (stringColor.Length == 6)
	{
	colorInt = (colorInt << 8) | 0xff;
	}
	components[0] = ((float)((colorInt & 0xff000000) >> 24)) / 255.0f;
	components[1] = ((float)((colorInt & 0x00ff0000) >> 16)) / 255.0f;
	components[2] = ((float)((colorInt & 0x0000ff00) >> 8)) / 255.0f;
	components[3] = ((float)(colorInt & 0x000000ff)) / 255.0f;
	altParseFailed = false;
	}
	}
	else if (stringColor.Length > 0 && stringColor[0] == '{')
	{
	stringColor = stringColor.Substring(1, stringColor.Length-2);
	string[] mgComponents = stringColor.Split(' ');
	if (mgComponents.Length == 4)
	{
	altParseFailed = false;
	string[] expectedPrefixes = {"R:", "G:", "B:", "A:"};
	for (int i = 0; i < 4; i++)
	{
	if (mgComponents[i].StartsWith(expectedPrefixes[i], StringComparison.OrdinalIgnoreCase))
	{
	string strToParse = mgComponents[i]
	.Remove(expectedPrefixes[i], StringComparison.OrdinalIgnoreCase)
	.Trim();
	int val = 0;
	altParseFailed |= !int.TryParse(strToParse, out val);
	components[i] = ((float) val) / 255f;
	}
	else
	{
	altParseFailed = true;
	break;
	}
	}
	}
	}
	if (altParseFailed)
	{
	if (errorMessages) { DebugConsole.ThrowError("Failed to parse the string \"" + stringColor + "\" to Color"); }
	return Color.White;
	}
	}
	else
	{
	for (int i = 0; i < 4 && i < strComponents.Length; i++)
	{
	float.TryParse(strComponents[i], NumberStyles.Float, CultureInfo.InvariantCulture, out components[i]);
	}
	if (components.Any(c => c > 1.0f))
	{
	for (int i = 0; i < 4; i++)
	{
	components[i] = components[i] / 255.0f;
	}
	//alpha defaults to 1.0 if not given
	if (strComponents.Length < 4) components[3] = 1.0f;
	}
	}
	return new Color(components[0], components[1], components[2], components[3]);
	}

I guess you can put there comma delimited color parts, or name of monogame color https://docs.monogame.net/api/Microsoft.Xna.Framework.Color.html

colors.mp4

[Tropingenie]

I see. I would guess (too tired to read the code) I hit an edge case where it accepted the parenthesis as part of the number and just silently failed on them. Still not sure that is particularly expected behaviour, but this also seems to be an edge case.

Also, did not know I could just use words... Wish I knew that before I put in all the signal checks. I guess I need to fix them anyways.

[Regalis11]

This doesn't seem like a bug: due to the parentheses, parsing the first and last component of the color fail, allowing it to only parse the green component.