-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show identity overrides pagination warning #4838
Comments
Related to #4664 |
As discussed with @khvn26 , this isn't as simple as just getting the UI to display a warning, because the UI doesn't have access to a server key needed to retrieve the environment document and determine if the LINK header is there. We'll need to implement something in the API to provide this information to the UI. |
@khvn26 does the |
@matthewelwell
|
@jasonw-rr sorry, I'm not sure what you mean by 'instead' ? Our intention is to display this warning in the admin UI, yes. |
@matthewelwell We can access to server-side environment key via Admin UI, why can't we use it to get |
Currently, when
/api/v1/environment-document
starts serving paginated responses due to total overrides exceeding the 1MB response size limit, there's no way for the user to find out unless they notice missing overrides during local evaluation.This will be the case for quite some time until all the server SDKs are updated to support pagination.
For now, we should check for additional pages and add a UI warning in the Environment context saying the following text:
Use the logic below to determine whether the banner should be shown:
The text was updated successfully, but these errors were encountered: