-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider auto-publishing workflow for every PR #2119
Comments
We're unable to unpublish our published package versions automatically with ease (less than 72 hours published) due to our package hierarchy (which was tested in #2377). This could be alleviated if we migrate to using a single Marking as blocked until we are able to unpublish NPM package versions and should be revisited after: |
IIUC and this won't be possible, perhaps we could close this issue. |
I think it might be possible after: |
Considering we can't unpublish versions, I wonder if we should go the simple way and run our installation checks on existent tags, like the |
That does seem reasonable - I'd be good if we could test out the functionality before we go into release. Maybe there is a way to test out the functionality locally. Would we deprecate fuels-ts/.github/workflows/pr-release.yaml? |
I don't think so, or not necessarily. The ability to publish PRs in isolation is handy. |
Wonderful! IMO - the following workflow doesn't work well: fuels-ts/.github/workflows/pr-release.yaml Lines 10 to 11 in 5daeea4
I believe a more manual approach, using the |
I agree, but are we still in the scope of this issue? 🙂 Otherwise, could we close this and perhaps create a new one based on your suggestion? |
Problem
Currently, we can have auto-publishing tags for the PRs we chose using this flag:
fuels-ts/.github/workflows/pr-release.yaml
Line 11 in 5daeea4
This is manual and error-prone; one must always turn it on and off.
Another problem is that published tags are left behind; the registry is massive.
click to see screenshot
Solution
We should consider cleaning this up and automating this workflow.
One idea is to turn on auto-publishing for every PR automatically.
merged
ordeleted
, all published tags for that PR are deleted from the registryThe text was updated successfully, but these errors were encountered: