Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review how create fuels install dependencies #3481

Closed
arboleya opened this issue Dec 13, 2024 · 4 comments
Closed

Review how create fuels install dependencies #3481

arboleya opened this issue Dec 13, 2024 · 4 comments
Labels
bug Issue is a bug

Comments

@arboleya
Copy link
Member

When I run bun create fuels, the generated app doesn't contain a bun.lockb file.

Only a after running:

$ bun install
[0.40ms] ".env.local"
bun install v1.0.25 (a8ff7be6)
[10.35ms] migrated lockfile from package-lock.json

 127 packages installed [1.65s]

Same with pnpm, I only get the pnpm-lock.yaml file after running pnpm install inside the app.

It's worth also double-checking how npm is behaving.

@arboleya arboleya added the bug Issue is a bug label Dec 13, 2024
@arboleya
Copy link
Member Author

@danielbate @Dhaiwat10 Thoughts on this one?

I'm just trying to remember how this was initially done and if this behavior is expected.

@Dhaiwat10
Copy link
Member

@arboleya there was an attempt to detect the package manager that the user used to initialize the project, but we did not succeed. I think as of now, the CLI always uses npm to install dependencies unless the user explicitly passes the package manager of their choice via a flag. (eg. bun create fuels --bun)

I noticed that create-next-app now auto-detects the package manager you use, so maybe there is a breakthrough there and we should re-visit this problem.

@danielbate
Copy link
Member

Yes we only have it setup via the flag. Maybe this issue should be a feature request to add better support for package manage detection, make sure said manager is used throughout and deprecate the flag.

@arboleya
Copy link
Member Author

Closing in favor of:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

No branches or pull requests

3 participants