Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validation and handling of unsafe integers #3491

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: validation and handling of unsafe integers #3491

wants to merge 8 commits into from
+72 −0

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Dec 19, 2024 •
edited by arboleya
Loading

Release notes

In this release, we:

  • Improved validation and handling of unsafe integers in BigNumberCoder

Summary

  • Any number bigger than Number.MAX_SAFE_INTEGER, encoded using the BigNumber coder, could lead to malformed data. We should ensure that the numbers of MAX_SAFE_INTEGER are encoded correctly and throw an error when attempting to handle a number more than this value.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Dec 19, 2024
@petertonysmith94 petertonysmith94 self-assigned this Dec 19, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 11:34am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 11:34am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 11:34am

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3491 will degrade performances by 44.62%

Comparing ps/fix/issue-with-big-numbers (c1eed36) with master (41c72fb)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master ps/fix/issue-with-big-numbers Change
❌ should successfully conduct a custom transfer between wallets (x20 times) 50.3 ms 90.8 ms -44.62%

@petertonysmith94 petertonysmith94 marked this pull request as ready for review December 20, 2024 17:29
Dhaiwat10
Dhaiwat10 previously approved these changes Dec 21, 2024
View reviewed changes
arboleya
arboleya previously approved these changes Dec 23, 2024
View reviewed changes
.changeset/orange-moles-leave.md Outdated Show resolved Hide resolved
@petertonysmith94 petertonysmith94 changed the title fix: handling very large numbers gracefully fix: validation and handling of unsafe integers Dec 23, 2024
@petertonysmith94 petertonysmith94 dismissed stale reviews from arboleya and Dhaiwat10 via b68944c December 23, 2024 09:53
arboleya
arboleya previously approved these changes Dec 23, 2024
View reviewed changes
danielbate
danielbate previously approved these changes Dec 30, 2024
View reviewed changes
@petertonysmith94 petertonysmith94 marked this pull request as draft December 30, 2024 11:10
@petertonysmith94 petertonysmith94 marked this pull request as ready for review December 30, 2024 13:30
@arboleya arboleya requested a review from danielbate December 30, 2024 14:56
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.84%(+0.01%) 70.55%(+0.08%) 75.5%(+0%) 77.8%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 78.08%
(+1.37%)		 84%
(+0%)		 88.81%
(+0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle large number values gracefully
4 participants
@petertonysmith94 @arboleya @danielbate @Dhaiwat10