Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ABI parser #3089

Open
wants to merge 16 commits into
base: np/feat/abi-refactor
Choose a base branch
from
Open

feat: ABI parser #3089

wants to merge 16 commits into from

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Sep 3, 2024

Summary

Adds the parsing functionality for an ABI. The Abi interface outputted by AbiParser will be the (hopefully) unchanging interface that will be used both by us in coders and typers, as well as external users who wish to work with the abi but not be affected by changing specifications.

The AbiParser output is tested both by a comprehensive test in this PR as well as #3249 and #3402 which are based off of this PR and are directly consuming the output.

Flowcharts describing how types are parsed

image

image

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the feat Issue is a feature label Sep 3, 2024
@nedsalk nedsalk self-assigned this Sep 3, 2024
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 0:33am
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 0:33am
ts-api-docs ❌ Failed (Inspect) Dec 31, 2024 0:33am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 0:33am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 0:33am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Dec 31, 2024 0:33am

Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #3089 will degrade performances by 17.21%

Comparing ns/feat/abi-parser (a2f0004) with np/feat/abi-refactor (1390116)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark np/feat/abi-refactor ns/feat/abi-parser Change
should successfully conduct a custom transfer between wallets (x20 times) 99.4 ms 120 ms -17.21%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants