Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean subtraction in FPCA #646

Open
igudav opened this issue Jan 25, 2025 · 1 comment
Open

Mean subtraction in FPCA #646

igudav opened this issue Jan 25, 2025 · 1 comment

Comments

@igudav
Copy link

igudav commented Jan 25, 2025

In FPCA the mean is subtracted twice: first explicitly by a _center_if_necessary function and then implicitly inside the sklearn PCA. The mean subtracted by the inner PCA is not a zero vector. Is it an intended behavior or the inner call should be to the TruncatedSVD method instead of the PCA?

@vnmabus
Copy link
Member

vnmabus commented Jan 25, 2025

@aleexarias As you are improving now the FPCA module, could you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants