Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot upload website logo #1787

Open
dractyl opened this issue Nov 2, 2024 · 6 comments
Open

[Bug]: Cannot upload website logo #1787

dractyl opened this issue Nov 2, 2024 · 6 comments

Comments

@dractyl
Copy link

dractyl commented Nov 2, 2024

Operating system

Mac OS Sonoma 14.6.1 (Apple Silicon)

Publii version

0.46.2 (build 16966)

Post editor

None

Bug description

When I upload a picture to be used as my website logo, I get an “Upload in progress…” spinner which never completes. The type of picture doesn’t seem to make a difference, and there is no error in the Javascript Console (from the DevTools).

I am using Mellisa but I also had this same problem during the summer with Massively and commented on it here: #1606

Steps to reproduce

  • Click on "Theme"
  • Click on "Choose File" under "Website Logo"
  • Select file in dialog
  • Wait forever

Relevant log output

No relevant log output
@dractyl
Copy link
Author

dractyl commented Nov 2, 2024

I should note that uploading pictures in other places, like a page or post, works fine.

@dractyl
Copy link
Author

dractyl commented Nov 2, 2024

"Image" in the "Hero section", also under "Theme", exhibits the same broken behavior.

Same with Site Settings -> Open Graph -> Fallback Image.

Authors -> <My Name> -> Avatar and Featured Image -> Avatar doesn't work, but "Featured Image" works correctly. That's probably useful.

@dractyl
Copy link
Author

dractyl commented Nov 18, 2024

Looking at bug #1810 I checked my own file system. I do not have the same pattern of behavior as him (I have an input/media/website directory), but I notice that I have various versions of the files there that have been uploaded but failed to complete. That might also provide a hint as to the source of the issue.

Screenshot 2024-11-18 at 16 34 01

Clearly uploading is generally broken in some way, which would seem like an issue to acknowledge. (Order #29181 - Ticket #29184 - plugins and themes with 3 months of support are kind of useless if the base product is broken).

@dziudek
Copy link
Collaborator

dziudek commented Dec 16, 2024

@dractyl - do you observe this issue with all images or only with the selected ones? The described behaviour suggest that there is some bug during processing images by the image processing library. Please also try to change under App settings Sharp to Jimp (Images resize engine) - maybe it will help

@dractyl
Copy link
Author

dractyl commented Dec 17, 2024

It was already on Jimp. The option specifically says that Sharp "can cause issues with some images", so I must have changed it to Jimp right after install (I had also disabled the WebP format as instructed by the warning box).

I changed it back to Sharp and now things appear to be working. I was sure I had tried that, but seemingly not.

Nonetheless, Jimp does work occasionally as I noted in the second comment. Whatever differentiates "Avatar" and "Featured Image" in "Authors -> -> Avatar and Featured Image" would seem to trigger the bug (the former fails and the latter works with Jimp set).

What kinds of image problems am I likely to encounter with Sharp.

@dziudek
Copy link
Collaborator

dziudek commented Dec 18, 2024

@dractyl - so the problem is with image and incompatiblity with Jimp. I will try to check if I can detect these issues and display some notice for the user during upload in v.0.47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants