Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS Left Side-Bar in fullscreen #199

Open
iErod opened this issue Oct 3, 2024 · 9 comments
Open

MacOS Left Side-Bar in fullscreen #199

iErod opened this issue Oct 3, 2024 · 9 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@iErod
Copy link

iErod commented Oct 3, 2024

I have FirefoxGX on both MacOS and Windows and it works great on Windows, but whenever I go to fullscreen on Mac, the Left Side-Bar glitches out. I know it's not fully tested on Mac, but was wondering if there was any work around?

Screenshot 2024-10-03 at 15 18 53 Screenshot 2024-10-03 at 15 19 10
@Godiesc
Copy link
Owner

Godiesc commented Oct 3, 2024

Main language: Spanish

hi,
you are right, I don't have a MacOS to test the theme, 2 issues seems to happened, in fullscreen the window controls disappear (I guess is a MAC behavior) and part of the sidebar keeps when it supposed to disappear in fullscreen.

If you have knowledgeable with css and the developer console maybe we can try some solution.

@Godiesc Godiesc added the bug Something isn't working label Oct 3, 2024
@iErod
Copy link
Author

iErod commented Oct 4, 2024

I don't know much about css, but I had tried changing this code to the code below in ogx_left-sidebar.css. It kept the bookmarks in the screen, but it was misaligned with the top left tab still, but in fullscreen in a video, there was a grey bar on the left where the bookmark used to be. If you give me options to try, I can try and give you feedback, but unfortunately, I do not know much about css.

Original Code
image

Tested Code
image

@Godiesc
Copy link
Owner

Godiesc commented Oct 4, 2024

Main language: Spanish

hi again. :)
I give you some code but I need you add in ogx_trick.css file and with the original theme without any of your edits.

This code will try to remove completely the sidebar on fullscreen:

@media (-moz-platform: macos) {
  :root:is([sizemode="fullscreen"]) #PersonalToolbar{
    display: none !important;
  }
}

@iErod
Copy link
Author

iErod commented Oct 4, 2024

That worked and fully got rid of it in fullscreen.
image

@Godiesc
Copy link
Owner

Godiesc commented Oct 4, 2024

do you mean my code did the work or you made another change?

It looks better, but it is just a grey bar on the side now.

@iErod
Copy link
Author

iErod commented Oct 4, 2024

My original comment was wrong, I had forgotten to remove the other code in ogx_left-sidebar.css. I removed that code and with your added code, it works, just no bookmarks in fullscreen obviously. The second comment is what it looks like now.

@Godiesc
Copy link
Owner

Godiesc commented Oct 4, 2024

so, if the code works flawless I will add the code to the theme in the ogx_left-sidebar.css.

it works, just no bookmarks in fullscreen obviously

Firefox don't show bookmarks-bar in fullscreen by default, A good improvement should be that sidebar shows like the other UI on 'hover' but I don't know how to do it.

@iErod
Copy link
Author

iErod commented Oct 5, 2024

It works, but if possible I would want to see the bookmarks when the browser is in fullscreen, but be hidden when a video or anything else is in fullscreen.

@Godiesc Godiesc added the enhancement New feature or request label Dec 13, 2024
@Godiesc
Copy link
Owner

Godiesc commented Jan 6, 2025

hi again,
I updated the files for the new Firefox version releasing tomorrow and added this feature to keep the left-sidebar in fullscreen mode, but in MacOS I can't test it.
Pls tell me how looks in your OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants