Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause the timer when the game is hidden #477

Open
LeonardoBraga opened this issue Jun 13, 2019 · 0 comments · May be fixed by #478
Open

Pause the timer when the game is hidden #477

LeonardoBraga opened this issue Jun 13, 2019 · 0 comments · May be fixed by #478

Comments

@LeonardoBraga
Copy link

As suggested by @kosamari in this Twitter thread, I'm creating a GH issue to track a feature proposal of pausing the game timer when the app is sent to the background or is hidden.

Let me know if any additional information is required. I'll send a PR for revision soon.

Thank you!

LeonardoBraga added a commit to LeonardoBraga/proxx that referenced this issue Jun 13, 2019
- Use the Page Visibility API to abort the timer increment when `documentvisibilityState` is `hidden`.
- Tweaked the time span logic to allow for pause/resume.

Closes GoogleChromeLabs#477
LeonardoBraga added a commit to LeonardoBraga/proxx that referenced this issue Jun 13, 2019
- Use the Page Visibility API to abort the timer increment when `document.visibilityState` is `hidden`
- Tweaked the time span logic to allow for pause/resume

Closes GoogleChromeLabs#477
@LeonardoBraga LeonardoBraga linked a pull request Jun 13, 2019 that will close this issue
@LeonardoBraga LeonardoBraga changed the title Pause the timer when the game is sent to the background or hidden Pause the timer when the game is hidden Jun 13, 2019
LeonardoBraga added a commit to LeonardoBraga/proxx that referenced this issue Jun 14, 2019
…API to abort the timer increment when `document.visibilityState` is `hidden`- Tweaked the time span logic to allow for pause/resumeCloses GoogleChromeLabs#477
LeonardoBraga added a commit to LeonardoBraga/proxx that referenced this issue Jun 14, 2019
…API to abort the timer increment when `document.visibilityState` is `hidden`- Tweaked the time span logic to allow for pause/resumeCloses GoogleChromeLabs#477
LeonardoBraga added a commit to LeonardoBraga/proxx that referenced this issue Jun 17, 2019
- Use the Page Visibility API to abort the timer increment when `document.visibilityState` is `hidden`
- Tweaked the time span logic to allow for pause/resume

Closes GoogleChromeLabs#477
LeonardoBraga added a commit to LeonardoBraga/proxx that referenced this issue Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant