feat: add domain name validation #925
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
commented
Jan 26, 2025
instance/conn_name.go
Outdated
| @@ -27,6 +27,8 @@ var ( | |||
| // Additionally, we have to support legacy "domain-scoped" projects | |||
| // (e.g. "google.com:PROJECT") | |||
| connNameRegex = regexp.MustCompile("([^:]+(:[^:]+)?):([^:]+):([^:]+)") | |||
| // The domain name pattern in accordance with RFC 1035, RFC 1123 and RFC 2181. | |||
| domainNameRegex = regexp.MustCompile("^[A-Za-z0-9-]{1,63}\\.[A-Za-z]{2,6}$") | |||
There was a problem hiding this comment.
This is just placeholder regex as same regex used in Java Connector will not compile in Go.
panic: regexp: Compile(`^(?=.{1,255}$)(?!-)[A-Za-z0-9-]+(\.[A-Za-z0-9-]+)*\.[A-Za-z]{2,}$`): error parsing regexp: invalid or unsupported Perl syntax: `(?=`
There was a problem hiding this comment.
Using this regex as of now: https://regex101.com/library/SEg6KL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve error handling and error messages returned to end user, we should
validate domain name prior to resolving it. This will allow for differentiating error
messages for invalid connection names vs failed DNS resolution.
Fixes #923