Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requiremtns.txt needs to be updated #295

Open
DariusNafar opened this issue Oct 6, 2021 · 6 comments
Open

requiremtns.txt needs to be updated #295

DariusNafar opened this issue Oct 6, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request Urgent

Comments

@DariusNafar
Copy link
Collaborator

@hossein

put the important stuff from your virtual environment into the requriements.txt with their version on git. like this:
image
also add spacy , networkx , numpy , request, panda and tqdm

@hfaghihi15
Copy link
Collaborator

I am not sure if everything in my virtual environment is quite necessary for running the framework.

We have to check this with a clean new installation of an environment and by resolving the dependencies one by one and then freezing that environment as the minimum requirements.

@guoquan
Copy link
Collaborator

guoquan commented Oct 7, 2021

Suggestion: try to keep only necessary ones for the framework in the root requirements.txt, not the ones needed by the examples.
Each example is an independent project using the framework and it has its own requirements.txt.

@hfaghihi15 hfaghihi15 added enhancement New feature or request Urgent labels Oct 13, 2021
@hfaghihi15
Copy link
Collaborator

@AdmiralDarius Do you have a version with the minimum requirement setting or is anyone looking to make this right now?

@hfaghihi15
Copy link
Collaborator

@AdmiralDarius please explain your issue with the torch versions upper than 1.8.1 and suggest a possible solution to fix that in the framework.

@DariusNafar
Copy link
Collaborator Author

On the most recent version of develop_newLC i tried torch 1.9.1 and torch 1.10 and the problem is resolved

@DariusNafar
Copy link
Collaborator Author

but on the main branch if i run wiqa_aug.py with torch 1.9.1 i get this:


ModuleNotFoundError Traceback (most recent call last)
/content/DomiKnowS/examples/WIQA/WIQA_aug.py in ()
2 import torch
3 from transformers import AdamW
----> 4 from regr.program.loss import NBCrossEntropyLoss, BCEWithLogitsIMLoss
5 from regr.program.metric import MacroAverageTracker, PRF1Tracker, MetricTracker, CMWithLogitsMetric, DatanodeCMMetric
6 import logging

5 frames
/content/DomiKnowS/regr/program/init.py in ()
----> 1 from .program import LearningBasedProgram
2 from .model_program import POIProgram, IMLProgram, POILossProgram, SolverPOIProgram
3 from .callbackprogram import CallbackProgram

/content/DomiKnowS/regr/program/program.py in ()
5 from ..utils import consume, entuple, detuple
6 from .model.base import Mode
----> 7 from ..sensor.pytorch.sensors import TorchSensor
8
9

/content/DomiKnowS/regr/sensor/init.py in ()
----> 1 from .sensor import Sensor
2 from .learner import Learner

/content/DomiKnowS/regr/sensor/sensor.py in ()
1 from typing import Dict, NoReturn, Any
2 import abc
----> 3 from ..graph.base import BaseGraphTreeNode
4
5

/content/DomiKnowS/regr/graph/init.py in ()
5 from .property import Property
6 from .trial import Trial
----> 7 from .dataNode import DataNode, DataNodeBuilder

/content/DomiKnowS/regr/graph/dataNode.py in ()
4 import re
5 from .dataNodeConfig import dnConfig
----> 6 from torch.tensor import Tensor
7
8 from ordered_set import OrderedSet

ModuleNotFoundError: No module named 'torch.tensor'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Urgent
Projects
None yet
Development

No branches or pull requests

3 participants