Feat: Email confirmation system #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubaryt
force-pushed
the
feat/email-confirmation
branch
from
d72a4e8 to
c6f7164
Compare
Norbiros
requested changes
Feb 6, 2025
Kubaryt
force-pushed
the
feat/email-confirmation
branch
from
fefa35a to
dbf7ab6
Compare
# Conflicts: # frontend/openapi/api/openapi.json # Conflicts: # backend/src/utils/error.rs
… why it doesnt work on gmail
…ed email on /login when parameter redirect_from_confirming is set to true, minor changes and fixes
Kubaryt
force-pushed
the
feat/email-confirmation
branch
from
dbf7ab6 to
cf3139c
Compare
Kubaryt
force-pushed
the
feat/email-confirmation
branch
from
cf3139c to
b047115
Compare
Kubaryt
force-pushed
the
feat/email-confirmation
branch
from
a2b0e64 to
35aaaa0
Compare
Norbiros
requested changes
Feb 11, 2025
| @@ -0,0 +1,92 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Add comment describing how it was generated
| let smtp_client = &app_state.smtp_client; | ||
|
|
||
| let html = self.parse_placeholders()?; | ||
|
|
||
| let logo_attachment = Attachment::new_inline("hack4krak_logo".to_string()).body( | ||
| std::fs::read("src/utils/emails_assets/images/hack4krak_logo_black.webp") |
There was a problem hiding this comment.
Use tokio, we don't want to lag entire thread :3
| "user".to_string(), | ||
| "link".to_string(), | ||
| "link".to_string(), | ||
| "link".to_string(), |
There was a problem hiding this comment.
Use replace all, do not define placeholders 3 times
| ("user".to_string(), register_json.name.clone()), | ||
| ("link".to_string(), confirmation_link.clone()), | ||
| ("link".to_string(), confirmation_link.clone()), | ||
| ("link".to_string(), confirmation_link), |
| .await?; | ||
|
|
||
| let confirmation_link = format!( | ||
| "{}/{}", |
There was a problem hiding this comment.
format! ain't efficent, use push_srt
| use uuid::Uuid as uuid_gen; | ||
|
|
||
| #[derive(Serialize, Deserialize, Debug)] | ||
| pub struct UserInfo { |
There was a problem hiding this comment.
Suggested change
| pub struct UserInfo { | |
| pub struct UserInformation { |
| ColumnDef::new(EmailConfirmation::ExpirationDate) | ||
| .timestamp() | ||
| .not_null() | ||
| .extra("DEFAULT NOW() + INTERVAL '30 minutes'".to_string()), |
There was a problem hiding this comment.
DB shouldn't be responsible for business logic... Move this + 30 to backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #130
Features: