New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Proper 404 error #146

Open

Norbiros opened this issue Feb 5, 2025 · 6 comments

Labels

Member

Norbiros commented Feb 5, 2025

My idea

Now actix handles 404 errors, and because of that they don't obey proper format

github-project-automation bot added this to Development Board

Contributor

wikipop commented Feb 7, 2025

What?

Member

Kubaryt commented Feb 7, 2025

What?

real

Norbiros added the scope: backend label

Member Author

Norbiros commented Feb 8, 2025

What does https://api.hack4krak.pl/skibidi return? Does it obey format defined for other errors message, id, status?

Contributor

wikipop commented Feb 8, 2025

I regret to inform that half of ours endpoints that return 404 don't implement this standard

Member Author

Norbiros commented Feb 8, 2025

Yeah, all of them where we don't have registered endpoint. Response in case of /skibidi is managed by actix, not us. And this issue is about changing that.

Contributor

wikipop commented Feb 8, 2025 •

edited

Loading

Your right, there is also not standardized 404 returned when path param is not provided e.g. teams /teams/team/ -> 404 /teams/team/1 -> 404 with body

Norbiros moved this to Todo in Development Board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment