Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better fromJSON error handling #3

Open
deavmi opened this issue Dec 30, 2022 · 0 comments
Open

Better fromJSON error handling #3

deavmi opened this issue Dec 30, 2022 · 0 comments
Assignees
@deavmi
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@deavmi
Copy link
Contributor

deavmi commented Dec 30, 2022 •
edited
Loading

We should be handling any runtime errors that occur either form wrong JSON types being requested based on the input struct type or if a field does not exist on the remote side, these should all be handled in fromJSON with an exception thrown.

Solution 1

What would make sense is we should type check each JSON field against a type we are going to, then fromJSON should throw a new type of PBException.
@deavmi deavmi self-assigned this Dec 30, 2022
@deavmi deavmi mentioned this issue Dec 30, 2022
Open
5 tasks
@deavmi deavmi added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deavmi deavmi

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deavmi