Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow DOM Suport #27

Open
matt-greenfield-15 opened this issue Dec 28, 2023 · 1 comment
Open

Shadow DOM Suport #27

matt-greenfield-15 opened this issue Dec 28, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@matt-greenfield-15
Copy link

Hi,

I have this plugin working just fine when rendering my React app in to the main DOM but styles are not moved to the Shadow DOM when I render my app in a shadow root.

Could that be an option on the plugin maybe?
It looks like it might be something here? https://github.com/HorusGoul/vite-plugin-stylex/blob/main/packages/vite-plugin-stylex/src/index.mts#L368

Or would it make more sense to use another vite plugin that takes the outputted CSS and moves it in to the shadow root?

thanks for your help

@HorusGoul HorusGoul added enhancement New feature or request help wanted Extra attention is needed labels Jan 4, 2024
@HorusGoul
Copy link
Owner

I'm curious why you need to render the styles within a shadow root. Styles generated by StyleX are atomic and shouldn't need isolation 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants