Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerDistribution Logged Values Are All Zero #118

Open
gcschmit opened this issue Feb 5, 2024 · 0 comments
Open

PowerDistribution Logged Values Are All Zero #118

gcschmit opened this issue Feb 5, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@gcschmit
Copy link
Contributor

gcschmit commented Feb 5, 2024

When running on the practice bot, all values logged until the PowerDistribution key are zero. This line of code from the Robot class should properly log these values:

LoggedPowerDistribution.getInstance();

However, it may need to changed to something like this:

LoggedPowerDistribution.getInstance(0, PowerDistribution.ModuleType.kRev);

where 0 is the CAN ID of the Rev Power Distribution Hub.

I recommend that we:

  • confirm the CAN ID of the Rev Power Distribution Hub on the practice bot
  • add a getPowerDistributionHubCANID method to RobotConfig
  • override as necessary in the RobotConfig subclasses if the CAN ID isn't the default value (is that 0?)
  • move the LoggedPowerDistribution.getInstance invocation into RobotContainer after the config object has been created
@gcschmit gcschmit added bug Something isn't working good first issue Good for newcomers labels Feb 5, 2024
@gcschmit gcschmit transferred this issue from HuskieRobotics/frc-software-2024 Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant