Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI #19

Open
FalseHonesty opened this issue Nov 24, 2018 · 3 comments · May be fixed by #25
Open

Travis CI #19

FalseHonesty opened this issue Nov 24, 2018 · 3 comments · May be fixed by #25
Labels
enhancement New feature or request

Comments

@FalseHonesty
Copy link
Member

This issue was mentioned in #18. I would like for CI to be setup for this project. Currently, the CI should not deploy anything, rather, it should just confirm that the project is building and that the gradle check task successfully passes. This will provide contributors with the piece of mind that their code is correct, and will provide maintainers with proof that all new code works.

@RDIL
Copy link
Contributor

RDIL commented Nov 25, 2018

Correct me if I’m wrong, but the install command is gradle assemble right?

@FalseHonesty
Copy link
Member Author

Install command? Do you mean build? The full build command is ./gradlew build

@FalseHonesty
Copy link
Member Author

Actually, Travis itself should not run any checks other than project building (and eventually possible deployment). Rather, it should defer to Danger to check for these issues. There are multiple plugins that I believe would be nice for us to use, such as KOTLIN_DETEKT, JUNIT, COMMIT_LINT, TODOIST, and possibly MENTION. In addition, there are probably some detections we should roll into the project ourselves, such as making sure tests are added for large changes, and more.

@FalseHonesty FalseHonesty added the enhancement New feature or request label Nov 29, 2018
@FalseHonesty FalseHonesty linked a pull request Dec 9, 2018 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants