Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trapping errors on Rename and perhaps other dialogs? #9305

Open
rdstern opened this issue Dec 12, 2024 · 0 comments
Open

Trapping errors on Rename and perhaps other dialogs? #9305

rdstern opened this issue Dec 12, 2024 · 0 comments
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Dec 12, 2024

@N-thony and perhaps @lilyclements I have been very happy with the improvements in the Rename dialog.

Now I have been trying to make it crash and have suceeded, but I had to try quite hard:

image

a) In the dialog, as shown, I first made 2 names the same. It just gave me a sensible error message.
b) Then I made some spaces in names and it put dots in for me. Even better!
c) Then I started a name with numbers and that gave me the dreaded exception error and I'm now going to have to crash out.

Now we could try and catch this too - which we do on the simple single rename dialog. Maybe we should - as starting with an illegal value is pretty likely from R-Instat users.

But I assume the Rename with could also generate an error similarly on occasion, and it will be hard to trap each of those?

I'm wondering if the @N-thony undo could come to our rescue here? Could it trap a serious error, like this give a general message, like "Serious error generated, so keeping the dataframe as before." Then simply do an undo, so keeping the "old" data frame?

@rdstern rdstern added this to the 0.8.1 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant