-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo harness: 3+ viewers using a common JSON annotation format #17
Comments
Acceptance criteria for initial demos:
|
Of the existing demos, the Google Model Viewer demo needs an additional glove annotation label. The X3D demo needs an additional glove annotation label, and to load the annotations from JSON input. |
Here is the JSON currently used by the Google Model Viewer demo. Need to add glove annotation and change face mask label to "visor".
|
Updated model-viewer demo: https://codesandbox.io/s/model-viewer-annotations-demo-3k5tqo |
Perfect, thanks! I'm also adding the new JSON used by the updated demo:
|
I've also updated #18, but here is the Aleph viewer demo loading the same annotation information as the other two examples. Specifically, it loads an annotation for the visor and the glove on the Astronaut 3D model. It loads the annotations from an external JSON file, as well. https://codesandbox.io/s/aleph-annotation-demo-teh3pf?file=/index.html
It's worth noting the format is different for Aleph compared to Google Model Viewer, but with the exception of the scale tag, the information is equivalent and interchangeable between those two viewers. |
I've created a Voyager version of the demo here: https://codesandbox.io/s/voyager-annotations-demo-o9l1rq?file=/index.html The relevant JSON for the annotations is as follows:
|
A similar (but not exactly the same) SketchFab demo has been contributed via the IIIF 3D Slack: https://jsfiddle.net/nebulousflynn/uykbgjaw/1/ |
I have created VIEWER_JSON_DEMOS.md in the associated repository to better track the growing number of demos and updates to the demos over time. I've modified the top post as well, which should be up to date as of this date of this comment. |
Thanks for the thorough documentation, Julie. Here are a few initial observations:
There were no obvious performance issues with any of the viewer tests. Regarding JSON formatting, the Aleph and Voyager key headers ("nodes", "annotations") benefit from human readability. I'll be curious to see the Sketchfab and X3D JSON. Please let me know if this thread isn't the place for such feedback and I'll move these comments to one of our IIIF TSG Google docs. |
As tracked in the Annotation Demo project and especially in #25, this task is now successfully complete. Our markdown document describing JSON viewer demos has been updated to reflect latest work. Thanks all! |
This is a task to create a milestone technical set of experiments that relates to user story #14, possibly others.
Acceptance criteria:
Current progress:
Progress needed:
After these points are finished, this task can potentially be closed and further work described as a new task (possibly in a GitHub project).
The text was updated successfully, but these errors were encountered: