Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exp database populator: migrate auth scheme #8631

Open
1 task
Tom-Willemsen opened this issue Jan 16, 2025 · 1 comment · May be fixed by ISISComputingGroup/ExperimentDatabasePopulator#14
Open
1 task
Assignees
Labels

Comments

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Jan 16, 2025

Issue Description

BusApps are turning off the old auth api in Feburary 2025 and so it will stop working then.

openapi specs in yaml and json copied to \\isis\shares\ISIS_Experiment_Controls\data for tickets\Ticket8631. We can contact JA from busapps teams if we have questions.

#8628 will be either a prerequisite or something we need to do alongside this issue.

How & Where?

https://github.com/ISISComputingGroup/ExperimentDatabasePopulator/blob/master/exp_db_populator/webservices_reader.py#L24

Reproducible (Yes/No)?

Will be reproducible if we attempt to use it after it's turned off

Additional Information

Some details in https://teams.microsoft.com/l/message/19:[email protected]/1737043299447?tenantId=3f66361c-a87e-4158-8f61-99e82db3cac8&groupId=d9946ec3-a454-424f-b673-5ffcb9f9ade0&parentMessageId=1737043299447&teamName=IBEX%20Developers&channelName=email-exp-controls&createdTime=1737043299447

Acceptance Criteria

  • Uses new api

How to Review

Before making a PR...

  • Provide verbose instructions for the reviewer to test that your changes work and fix the issue
  • Describe if/how you have implemented testing for this issue
  • Provide screenshots of the feature to help the reviewer if relevant

If not applicable, write "Not applicable"

...

To the reviewer: Make sure to update submodules!

@Tom-Willemsen
Copy link
Contributor Author

As far as I understand BusApps emails, it's just the auth bit that is impacted, we still use SOAP for the main get experiments call I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review
Development

Successfully merging a pull request may close this issue.

2 participants