Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K_v -> L_w is continuous #235

Closed
kbuzzard opened this issue Nov 25, 2024 · 2 comments
Closed

K_v -> L_w is continuous #235

kbuzzard opened this issue Nov 25, 2024 · 2 comments

Comments

@kbuzzard
Copy link
Collaborator

We have that it's a K-algebra homomorphism but we also need that it's continuous. This is the sorry in adicCompletionComapAlgHom in the file DedekindDomain.FiniteAdeleRing.BaseChange (line 230 at the time of writing).

@erdOne
Copy link
Contributor

erdOne commented Nov 26, 2024

This is

  cont := 
    letI : UniformSpace K := v.adicValued.toUniformSpace;
    letI : UniformSpace L := w.adicValued.toUniformSpace;
    UniformSpace.Completion.continuous_extension

I can open a PR but it might be faster if you just push it.
Edit: I opened a PR.

@kbuzzard
Copy link
Collaborator Author

kbuzzard commented Dec 1, 2024

Thanks!

@kbuzzard kbuzzard closed this as completed Dec 1, 2024
@github-project-automation github-project-automation bot moved this from Unclaimed to Completed in FLT Project Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

No branches or pull requests

2 participants