Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement API 1.2 new endpoint Session#Check #4

Closed
InfectedBytes opened this issue Nov 12, 2017 · 1 comment
Closed

Implement API 1.2 new endpoint Session#Check #4

InfectedBytes opened this issue Nov 12, 2017 · 1 comment

Comments

@InfectedBytes
Copy link
Owner

InfectedBytes commented Nov 12, 2017

Superseed loicteixeira#25

Waiting for gamejolt/doc-game-api#23 to be fixed

So the problem is basically that GameJolt misuses the success argument.
The success argument determines whether the request has succeeded or failed, but for the Session.Check call, they also use this value to say that there is no open session. So if it is false, it does not necessarily mean that the request has failed, it might also just mean that there is no open session.

@InfectedBytes
Copy link
Owner Author

It would be good if GameJolt fixes this, but for now I just go for a workaround:
If a request has actually failed, success is false and there is an additional message argument describing the problem. So if success is false, but there is no message argument, we can assume that the call has succeeded and we just don't have an open session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant