Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate data persistence to EFCore #20

Open
Issung opened this issue Mar 12, 2023 · 1 comment
Open

Migrate data persistence to EFCore #20

Issung opened this issue Mar 12, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Issung
Copy link
Owner

Issung commented Mar 12, 2023

This application saves data the user inputs like threads/boards to scrape across application closes/opens.

Originally it was done in a .txt file, very nasty.

Sometime mid 2021 I rewrote that to store the data in an sqlite database in a new class DataController.cs. This is okay but the implentation is a bit shit and there's no easy way to do migrations (changes do the database schema) which I would like have for the future.

I want to stick with SQLite but use EFCore over the top, it gives us migration ease "for free" and makes working with the database easier. https://learn.microsoft.com/en-us/ef/core/get-started/overview/first-app?tabs=netcore-cli

Need to decide if we try putting the existing Board/Thread classes into the DB as is, or if we have seperate classes for database storage and map them back and fourth. Needs discussion.

@Issung
Copy link
Owner Author

Issung commented Mar 12, 2023

While this is a bit complex its relatively simple because its a seperate class that manages all the data access on its own, all changes will likely be within this class and not affect much outside of it 👍

@Issung Issung added enhancement New feature or request good first issue Good for newcomers labels Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant