Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve initialization with Builder pattern #7

Open
vzahradnik opened this issue Aug 15, 2020 · 0 comments
Open

Improve initialization with Builder pattern #7

vzahradnik opened this issue Aug 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@vzahradnik
Copy link
Collaborator

Analog buttons will usually share the same pin. At the moment, we allow setting pin and inputPullUp flag for each button individually. This is not correct. Imagine that one button sets pin as inputPullUp and another sets the same pin to input only.

Builder pattern should solve this problem by not allowing to setup this flag on each individual button. Take into consideration memory restrictions.
@vzahradnik vzahradnik added the enhancement New feature or request label Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vzahradnik