Contributors Chat

[JeffSteinbok]

As opposed to using Discord or something like that, we can try this for chatting about PRs and such without overloading the issues that have been filed.

[JeffSteinbok]

@andy-cooper - We can try this instead of Discord for now.

[andy-cooper]

So, what I was trying to do with my fork and branch off of my fork was to isolate the code for the oscillation angle on the wall-mounted heaters. When I pseudo-enable it on my space heaters, I see the controls to set the oscillation angle, but apparently the people who have a wall heater don't see it. It's not quite clear to me whether or not they actually used the oscangle branch on my fork or the main branch on my fork, so it's a little hard to tell what went wrong there.

If things have been broken by my changes, I'll do my best to get that fixed rapidly.

[JeffSteinbok]

I'm updating my test VM now with the latest HA and I'll pull the code from Main and see if it works. I don't have a space heater, but I do have a tower fan and an air circulator. The latter supports angle setting.

[andy-cooper]

OK, great. One of these days I'll have to put together a test VM for myself. Right now I just run it against my live system. Hah. It does, however, provide motivation to fix it quickly.

[JeffSteinbok]

Still don't have the angle with what's in main at the moment.

Logger: homeassistant.components.number
Source: helpers/entity_platform.py:350
integration: Number (documentation, issues)
First occurred: 7:52:20 PM (1 occurrences)
Last logged: 7:52:20 PM

Error while setting up dreo platform for number
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 350, in _async_setup_platform
await asyncio.shield(awaitable)
File "/config/custom_components/dreo/number.py", line 101, in async_setup_entry
async_add_entities(add_entries(manager.fans))
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/dreo/number.py", line 74, in add_entries
if (de.device_definition.range[number_definition.attr_name+"_range"] is not None):
~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'horizontal_angle_range'

[JeffSteinbok]

Back to 0.6.2 has no issues.

I saw a different exception in the HA CLI when I ran "core logs" but it scrolled up so much I couldn't see the start of it.

[andy-cooper]

OK, another PR to fix the KeyError - #79 - hopefully that will get your angles back. The risks of coding without a device and not properly expanding the unit tests.

[JeffSteinbok]

I am going to move b4 to a released build soon. Please let me know if any of you have other regressions?

@andy-cooper @iRonin @iRonin @crowbarz

[iRonin]

I can have a look at it tomorrow the earliest.