Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on Active tab should not navigate away #82

Open
slominskir opened this issue Nov 13, 2024 · 2 comments
Open

Links on Active tab should not navigate away #82

slominskir opened this issue Nov 13, 2024 · 2 comments
Assignees

Comments

@slominskir
Copy link
Member

Clicking links on the Active tab to the Notification Snapshot page should probably open in a new tab to leave the Active tab monitoring running.

@slominskir
Copy link
Member Author

slominskir commented Nov 14, 2024

Or open in an iframe / dialog.

@slominskir
Copy link
Member Author

slominskir commented Jan 9, 2025

First attempt (iframe): #79

Second attempt (jquery UI dialog in shared lib): JeffersonLab/smoothness#33

Note: we could just add target="_blank" to anchors. That would be the quick and dirty fix. Popping an embedded dialog or panel is more user friendly though.

Another option is to merge the notification and active tabs such that there is no Notification tab any more.

@slominskir slominskir changed the title Links on Active tab should open in new tab Links on Active tab should not navigate away Jan 9, 2025
@slominskir slominskir self-assigned this Jan 9, 2025
@slominskir slominskir transferred this issue from JeffersonLab/jaws Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant