-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attributesWhitelist does not work since version 2.45.1 #1485
Comments
Format line cannot contain another line.
|
Still, this is not quite the correct behavior.
the user uses external HTML and it cannot have the class " How to make Thanks. |
Agree. I have (yet again) rolled back to v2.41.3. All versions after that is a mess. You end up using more time fixing errors (or mysterious deletions) in the generated HTML than you are using on actual writing. If you get the attributesWhitelist to work then it will begin to automatically delete headers, and when you fix that you cannot add attributes, if you fix that then suddenly anything is wrapped into endless spans with __custom_tag etc, after cleaning up titles are suddenly automatically removed and so on. The older versions had some flaws, you could live with that, but the newer versions are a mess. I have used hundreds of hours just to fix users writings / text because something odd have happen. I am a single individual who are running a free service. Obviously the problems occur around all the attribute and tag white and black -listing. It is a great idea but we really do not need parential guiding with HTML, classes or attributes. And when it not work, or one rule somehow breaks other rules, why not leave it completely out, or have it as opt-in? It is nice to have, not need to have, and certainly not if it not works as expected. And why on earth replace Well, sorry for the harsh words 🙂 Was just frustrated, have yet again used 4-5 hours to correct a text, and then finally ended up rolling back (again). Merry Christmas and a Happy New Year!! 🌲🎁🎀 |
Oh, by the way, why all those
|
Describe the bug
Since version 2.45.1 attributesWhitelist stopped working
I use this HTML:
But this does not work and removes the "div" tag along with the "style" attribute, and the text is of course not centered.
Only paragraphs remain:
To Reproduce
Steps to reproduce the behavior:
"attributesWhitelist": {all: "style"}
Expected behavior
The div with the "style" attribute should not be removed and the text should be centered.
Codepan example
https://codepen.io/abvas/pen/xbKKWZv?editors=1010
Desktop (please complete the following information):
Additional context
In v2.44.12 this all worked correctly.
Starting with v2.45.1 it no longer works (including in version 2.47.0)
The text was updated successfully, but these errors were encountered: