Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop function doesn't work (see last comment for Warning) #8

Closed
4 of 5 tasks
JohnyP36 opened this issue Oct 19, 2021 · 4 comments
Closed
4 of 5 tasks

Loop function doesn't work (see last comment for Warning) #8

JohnyP36 opened this issue Oct 19, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@JohnyP36
Copy link
Owner

Prerequisites

I tried to reproduce the issue when...

  • Other webextensions related to Youtube are disabled -- Just to ensure there is no issues or conflicts with other webbrowser extensions.
  • using a new, unmodified browser profile

Describe the issue

Since some weeks the function to loop your playlist doesn't work anymore.
So, it doesn't matter if I toggle on or off the loop button in the extension popup: it has no affect on www.youtube.com.

Screenshot(s)

No response

Browser & Extension version

MS Edge 94 & 1.6.4

Notes

I looked into your .js files, and into the source code of youtube.com, but for so far I didn't found the error.
Maybe youtube has change their code.

@JohnyP36
Copy link
Owner Author

JohnyP36 commented Oct 19, 2021

It only works in the mini player, but not in the normal view.

But changing

{return[...document.getElementsByClassName("header ytd-playlist-panel-renderer")[0].getElementsByClassName("style-scope yt-icon-button")].filter(t=>t.id=="button")}
in

{return[...document.querySelectorAll('div[id="header-contents"] div[id="playlist-action-menu"] button[aria-label="Loop playlist"]')].filter(t=>t.id=="button")}

also doesn't work - however it should work, because for some reason it only select the last query after the first one is selected. But because the first one can't be selected (is only available until div[id="playlist-action-menu"] if you don't load the miniplayer in YT), it will not selected the second query (just the button in main/normal view).

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale This issue or pull request is stale label Dec 2, 2021
@JohnyP36 JohnyP36 added help wanted Extra attention is needed and removed stale This issue or pull request is stale labels Dec 2, 2021
@JohnyP36 JohnyP36 pinned this issue Dec 2, 2021
@JohnyP36 JohnyP36 added enhancement New feature or request and removed enhancement New feature or request labels May 5, 2022
@JohnyP36
Copy link
Owner Author

Fixed by 5e8accb & e373571

@JohnyP36
Copy link
Owner Author

JohnyP36 commented Jan 9, 2024

Warnings

  1. Drawback: you can only loop a video in a playlist if you turn "loop playlist" on.
  2. The loop function for YouTube Music will only work if the language of YouTube is set to: English, German, French or Dutch.
    If you want this extension to support your language, please open an issue.

@JohnyP36 JohnyP36 changed the title Loop function doesn't work Loop function doesn't work (see last comment for Warning) Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant