Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: eslint does not report problems on tasks.json in VS Code #1219

Open
3 tasks done
danvk opened this issue Jan 9, 2024 · 3 comments
Open
3 tasks done

🐛 Bug: eslint does not report problems on tasks.json in VS Code #1219

danvk opened this issue Jan 9, 2024 · 3 comments
Labels
status: blocked Waiting for something else to be resolved type: bug Something isn't working :(

Comments

@danvk
Copy link
Contributor

danvk commented Jan 9, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

I created a new repo yesterday using create-typescript-app using the "everything" setting (woo!). I set up a few tasks in VS Code's tasks.json and pushed a PR, at which point I noticed that I was getting some eslint errors because of unsorted keys in my tasks.json.

These were reported via GitHub Actions CI and when I run pnpm lint, but they were not reported in VS Code like lint errors in .ts files are.

Actual

I would expect eslint issues in tasks.json to be reported in VS Code (so that I can quick fix them!).

Additional Info

I noticed that "json" is in the eslint.probe list in .code/settings.json, but maybe it also needs to be told about JSON files some other place?

Here's the PR and repo: danvk/gravlax#3

@danvk danvk added the type: bug Something isn't working :( label Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Jan 9, 2024
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @danvk for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @danvk! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this issue Jan 14, 2024
Adds @danvk as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#1219 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@JoshuaKGoldberg
Copy link
Owner

Hmm, looks like using eslint.probe for jsonc files isn't yet supported in vscode-eslint: microsoft/vscode-eslint#1786. Marking as blocked pending discussion there.

Worst case scenario, we can go back to eslint.validate. But that's described as old and legacy so I'd rather not for a bit.

@JoshuaKGoldberg JoshuaKGoldberg added status: blocked Waiting for something else to be resolved and removed status: accepting prs Please, send a pull request to resolve this! labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Waiting for something else to be resolved type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

2 participants