Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the broken test case in @testset "Stepping over kwfunc preparation" #620

Open
aviatesk opened this issue Mar 21, 2024 · 0 comments
Open

Comments

@aviatesk
Copy link
Member

This test case is broken on ≥v"1.11-".

@test frame.pc == JuliaInterpreter.nstatements(frame.framecode) - 1 broken=VERSIONv"1.11-"

We need to revisit the implementation of maybe_step_through_kwprep!

function maybe_step_through_kwprep!(@nospecialize(recurse), frame::Frame, istoplevel::Bool=false)
# XXX This code just does pattern-matching based on the current state of the compiler
# internals, which means this is very fragile against any future changes to those
# internals. We really need a more general and robust solution, but achieving that
# would mean simplifying and unifying how "keyword function" is represented and
# implemented. For the time being, our best bet is to keep tweaking it as best as we can.

Originally posted by @aviatesk in #615 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant