Capture Desktop on MAC #1
Comments
|
this is just a fork from chromium webrtc,I think you should file issue there? |
|
you can see some object-c samples: https://github.com/search?utf8=%E2%9C%93&q=webrtc&type= |
JumpingYang001
pushed a commit
that referenced
this issue
May 21, 2018
Presubmit check will test will new changes be overriden by autoroll or not. In more details presubmit will check: 1. Each dependency in third_party have to be specified in one of: a. THIRD_PARTY_CHROMIUM_DEPS.json b. THIRD_PARTY_WEBRTC_DEPS.json 2. Each dependency not specified in both files from #1 3. Changes won't be overriden by chromium third_party deps autoroll: a. Changes were made in WebRTC owned dependency b. Changes were addition of new Chromium owned dependency Bug: webrtc:8366 Change-Id: Ic5db24289e7fa461e0959f75cfbe81ecc65af4b5 Reviewed-on: https://webrtc-review.googlesource.com/77421 Reviewed-by: Karl Wiberg <[email protected]> Reviewed-by: Patrik Höglund <[email protected]> Commit-Queue: Artem Titov <[email protected]> Cr-Commit-Position: refs/heads/master@{#23301}
JumpingYang001
pushed a commit
that referenced
this issue
May 21, 2018
This reverts commit 4103b38. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add presubmit check for changes in 3pp > > Presubmit check will test will new changes be overriden by autoroll > or not. In more details presubmit will check: > 1. Each dependency in third_party have to be specified in one of: > a. THIRD_PARTY_CHROMIUM_DEPS.json > b. THIRD_PARTY_WEBRTC_DEPS.json > 2. Each dependency not specified in both files from #1 > 3. Changes won't be overriden by chromium third_party deps autoroll: > a. Changes were made in WebRTC owned dependency > b. Changes were addition of new Chromium owned dependency > > Bug: webrtc:8366 > Change-Id: Ic5db24289e7fa461e0959f75cfbe81ecc65af4b5 > Reviewed-on: https://webrtc-review.googlesource.com/77421 > Reviewed-by: Karl Wiberg <[email protected]> > Reviewed-by: Patrik Höglund <[email protected]> > Commit-Queue: Artem Titov <[email protected]> > Cr-Commit-Position: refs/heads/master@{#23301} [email protected],[email protected],[email protected] Change-Id: Ib016ee4ac58729c2c0d302a964dbac71b4ae64af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8366 Reviewed-on: https://webrtc-review.googlesource.com/77780 Reviewed-by: Artem Titov <[email protected]> Commit-Queue: Artem Titov <[email protected]> Cr-Commit-Position: refs/heads/master@{#23302}
JumpingYang001
pushed a commit
that referenced
this issue
May 25, 2018
Reland of CL https://webrtc-review.googlesource.com/c/src/+/77421 Copied description: -- Add presubmit check for changes in 3pp Presubmit check will test will new changes be overriden by autoroll or not. In more details presubmit will check: 1. Each dependency in third_party have to be specified in one of: a. THIRD_PARTY_CHROMIUM_DEPS.json b. THIRD_PARTY_WEBRTC_DEPS.json 2. Each dependency not specified in both files from #1 3. Changes won't be overriden by chromium third_party deps autoroll: a. Changes were made in WebRTC owned dependency b. Changes were addition of new Chromium owned dependency -- Also if commit message contains tag NO_AUTOIMPORT_DEPS_CHECK equal to True, than changes in chromium specific deps will be permitted. It is required for autoroller to be able to commit its changes and not to fail on presubmit check. Bug: webrtc:8366 Change-Id: I545a4778445855cf3db7cf257ca0cb63753aac06 Reviewed-on: https://webrtc-review.googlesource.com/78042 Reviewed-by: Patrik Höglund <[email protected]> Commit-Queue: Artem Titov <[email protected]> Cr-Commit-Position: refs/heads/master@{#23348}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Guidance on how to achieve this on Native? Any Xcode example
The text was updated successfully, but these errors were encountered: